Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318028: Remove unused class="centered" from FocusCycle.svg #16168

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Oct 12, 2023

Cleanup

A trivial modification which removes class="centered" from one of the <text> elements. It's a remnant from a previous version of the image.

Classes aren't used, all <text> elements are centered.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318028: Remove unused class="centered" from FocusCycle.svg (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16168/head:pull/16168
$ git checkout pull/16168

Update a local copy of the PR:
$ git checkout pull/16168
$ git pull https://git.openjdk.org/jdk.git pull/16168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16168

View PR using the GUI difftool:
$ git pr show -t 16168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16168.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 12, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318028: Remove unused class="centered" from FocusCycle.svg

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9728e21: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

Going to push as commit 7d31146.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 45b7aed: 8317433: Async UL: Only grab lock once when write():ing
  • 266636d: 8315940: ARM32: Move field resolution information out of the cpCache
  • e490cf9: 8317432: Async UL: Use memcpy instead of strcpy in Message ctr
  • 126f2ac: 8318006: remove unused net related coding
  • 4d90420: 8315026: ProcessHandle implementation listing processes on AIX should use getprocs64
  • 1082c0e: 8317677: Specialize Vtablestubs::entry_for() for VtableBlob
  • ec310fe: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object
  • ff0b397: 8317959: Check return values of malloc in native java.base coding
  • c88b387: 8317987: C2 recompilations cause high memory footprint
  • 993951b: 8316464: 3 sun/tools tests ignore VM flags
  • ... and 7 more: https://git.openjdk.org/jdk/compare/a8473b70797ef8fa0704774bfadbd84cb33a1d53...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2023
@openjdk openjdk bot closed this Oct 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@aivanov-jdk Pushed as commit 7d31146.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8318028-centered-FocusCycle.svg branch October 17, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants