Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms #16172

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 12, 2023

Trivial ProblemListing for some tests:

JDK-8318038 ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms
JDK-8318040 ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/findMonitorDeadlockedThreads/find006/TestDescription.java on macosx-aarch64
JDK-8318042 ProblemList java/nio/channels/vthread/BlockingChannelOps.java#direct-register with GenZGC


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms (Sub-task - P3)
  • JDK-8318040: ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/findMonitorDeadlockedThreads/find006/TestDescription.java on macosx-aarch64 (Sub-task - P4)
  • JDK-8318042: ProblemList java/nio/channels/vthread/BlockingChannelOps.java#direct-register with GenZGC (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16172/head:pull/16172
$ git checkout pull/16172

Update a local copy of the PR:
$ git checkout pull/16172
$ git pull https://git.openjdk.org/jdk.git pull/16172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16172

View PR using the GUI difftool:
$ git pr show -t 16172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16172.diff

Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.j… 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms Oct 12, 2023
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/label add core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk
The core-libs label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8318038
/issue JDK-8318040
/issue JDK-8318042

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8318040: ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/findMonitorDeadlockedThreads/find006/TestDescription.java on macosx-aarch64.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review October 12, 2023 19:41
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8318042: ProblemList java/nio/channels/vthread/BlockingChannelOps.java#direct-register with GenZGC.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms
8318040: ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/findMonitorDeadlockedThreads/find006/TestDescription.java on macosx-aarch64
8318042: ProblemList java/nio/channels/vthread/BlockingChannelOps.java#direct-register with GenZGC

Reviewed-by: rriggs, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 32ac72c: 8312522: Implementation of Foreign Function & Memory API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2023
@dcubed-ojdk
Copy link
Member Author

@RogerRiggs and @azvegint - Thanks for the fast reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

Going to push as commit 0983b54.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 64ee3c9: 8317266: Move nmethod::check_all_dependencies to codeCache.cpp and mark it NOT_PRODUCT
  • 32ac72c: 8312522: Implementation of Foreign Function & Memory API

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2023
@openjdk openjdk bot closed this Oct 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@dcubed-ojdk Pushed as commit 0983b54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8318038 branch October 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants