Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318072: DowncallLinker does not acquire/release segments in interpreter #16177

Closed
wants to merge 2 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Oct 13, 2023

Implement missing by-reference argument acquire/release functionality in DowncallLinker::invokeInterpBindings.

I've also simplified the related code a bit:

  • retIndexMap was not used. I've removed it
  • BindingInterpreter.StoreFunc::store's type argument was not used. Removed
  • UpcallLinker was redundantly collecting the move bindings for return values. Removed

I've added runs without specialization to the failing tests as well, so that we keep testing this.

Testing: jdk_foreign suite.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318072: DowncallLinker does not acquire/release segments in interpreter (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16177/head:pull/16177
$ git checkout pull/16177

Update a local copy of the PR:
$ git checkout pull/16177
$ git pull https://git.openjdk.org/jdk.git pull/16177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16177

View PR using the GUI difftool:
$ git pr show -t 16177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16177.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 13, 2023
@JornVernee JornVernee marked this pull request as ready for review October 13, 2023 08:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318072: DowncallLinker does not acquire/release segments in interpreter

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 32a60cf: 8317824: Beef up javadoc for base offset in var handles derived from layouts (mainline)
  • b12c471: 8317837: Leftover FFM implementation-only changes
  • 605c976: 8318039: GHA: Bump macOS and Xcode versions
  • 6273ab9: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
  • 7d31146: 8318028: Remove unused class="centered" from FocusCycle.svg
  • 45b7aed: 8317433: Async UL: Only grab lock once when write():ing
  • 266636d: 8315940: ARM32: Move field resolution information out of the cpCache
  • e490cf9: 8317432: Async UL: Use memcpy instead of strcpy in Message ctr
  • 126f2ac: 8318006: remove unused net related coding
  • 4d90420: 8315026: ProcessHandle implementation listing processes on AIX should use getprocs64
  • ... and 10 more: https://git.openjdk.org/jdk/compare/32ac72c3d35138f5253e4defc948304ac3ea1b53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2023
@eirbjo
Copy link
Contributor

eirbjo commented Oct 13, 2023

DowncallLinker is not spelled correctly in the PR and JBS issue. Fixing this could improve searchability.

@JornVernee JornVernee changed the title 8318072: DonwcallLinker does not acquire/release segments in interpreter 8318072: DowncallLinker does not acquire/release segments in interpreter Oct 13, 2023
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2023

Going to push as commit 1d54e73.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 56aa1e8: 8317683: Add JIT memory statistics
  • f7d6d7a: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e942f36: 8317535: Shenandoah: Remove unused code
  • 7cb2e6d: 8317514: Ensure MemorySegment is initialized before touching NativeMemorySegmentImpl
  • 9622de2: 8317372: Refactor some NumberFormat tests to use JUnit
  • 72c4dcb: 8317970: Bump target macosx-x64 version to 11.00.00
  • 32a60cf: 8317824: Beef up javadoc for base offset in var handles derived from layouts (mainline)
  • b12c471: 8317837: Leftover FFM implementation-only changes
  • 605c976: 8318039: GHA: Bump macOS and Xcode versions
  • 6273ab9: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
  • ... and 16 more: https://git.openjdk.org/jdk/compare/32ac72c3d35138f5253e4defc948304ac3ea1b53...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2023
@openjdk openjdk bot closed this Oct 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2023
@openjdk
Copy link

openjdk bot commented Oct 14, 2023

@JornVernee Pushed as commit 1d54e73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the InterpAcquire branch October 14, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants