Skip to content

8318086: [jvmci] RISC-V: Reuse target config from TargetDescription #16181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8318086: [jvmci] RISC-V: Reuse target config from TargetDescription #16181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f13696
remove unnecessary linuxOs in RISCV64HotSpotVMConfig.java
feilongjiang Oct 12, 2023
f7240d4
remove unused import
feilongjiang Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rnal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotJVMCIBackendFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ protected HotSpotConstantReflectionProvider createConstantReflection(HotSpotJVMC
}

private static RegisterConfig createRegisterConfig(RISCV64HotSpotVMConfig config, TargetDescription target) {
return new RISCV64HotSpotRegisterConfig(target, config.useCompressedOops, config.linuxOs);
return new RISCV64HotSpotRegisterConfig(target, config.useCompressedOops, target.linuxOs);
}

protected HotSpotCodeCacheProvider createCodeCache(HotSpotJVMCIRuntime runtime, TargetDescription target, RegisterConfig regConfig) {
Expand Down
4 changes: 0 additions & 4 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotVMConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@

import jdk.vm.ci.hotspot.HotSpotVMConfigAccess;
import jdk.vm.ci.hotspot.HotSpotVMConfigStore;
import jdk.vm.ci.services.Services;
import jdk.internal.util.OperatingSystem;

/**
* Used to access native configuration details.
Expand All @@ -38,8 +36,6 @@ class RISCV64HotSpotVMConfig extends HotSpotVMConfigAccess {
super(config);
}

final boolean linuxOs = OperatingSystem.isLinux();

final boolean useCompressedOops = getFlag("UseCompressedOops", Boolean.class);

// CPU Capabilities
Expand Down