Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8318154 : Improve stability of WheelModifier.java test #16185

Closed
wants to merge 4 commits into from

Conversation

Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Oct 13, 2023

Hi Revivers,

Part of stability improvement for the test case WheelModifier.java I have moved getLocationOnScreen() and getSize() into EDT, part of warning removal updated BUTTON1_MASK with BUTTON1_DOWN_MASK

Please review and let me know your suggestions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318154: Improve stability of WheelModifier.java test (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16185/head:pull/16185
$ git checkout pull/16185

Update a local copy of the PR:
$ git checkout pull/16185
$ git pull https://git.openjdk.org/jdk.git pull/16185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16185

View PR using the GUI difftool:
$ git pr show -t 16185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16185.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back Renjithkannath! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@Renjithkannath The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 13, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318154: Improve stability of WheelModifier.java test

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • a27fc7e: 8317994: Serial: Use SerialHeap in generation
  • 37eb986: 8154846: SwingNode does not resize when content size constraints are changed
  • 37aed6f: 8315362: NMT: summary diff reports threads count incorrectly
  • 1e930db: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 0275efa: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 77d40ce: 8318085: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-aarch64
  • 4ea1b99: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • 01ea1ef: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
  • 1d54e73: 8318072: DowncallLinker does not acquire/release segments in interpreter
  • ... and 20 more: https://git.openjdk.org/jdk/compare/993951b85e016475f4cd5079ae21bd5ce1f2830c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2023
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@Renjithkannath
Your change (at version 8b8aaac) is now ready to be sponsored by a Committer.

@Renjithkannath Renjithkannath changed the title 8169475 : WheelModifier.java fails by timeout JDK-8318154 : Improve stability of WheelModifier.java test Oct 16, 2023
@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

Going to push as commit 668d4b0.
Since your change was applied there have been 30 commits pushed to the master branch:

  • a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • a27fc7e: 8317994: Serial: Use SerialHeap in generation
  • 37eb986: 8154846: SwingNode does not resize when content size constraints are changed
  • 37aed6f: 8315362: NMT: summary diff reports threads count incorrectly
  • 1e930db: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 0275efa: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 77d40ce: 8318085: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-aarch64
  • 4ea1b99: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • 01ea1ef: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
  • 1d54e73: 8318072: DowncallLinker does not acquire/release segments in interpreter
  • ... and 20 more: https://git.openjdk.org/jdk/compare/993951b85e016475f4cd5079ae21bd5ce1f2830c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2023
@openjdk openjdk bot closed this Oct 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@aivanov-jdk @Renjithkannath Pushed as commit 668d4b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Renjithkannath Renjithkannath deleted the 8169475-v2 branch December 22, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants