8257743: Minimal build on AArch64 failed with --disable-precompiled-headers

[shqking]

The build failed due to undeclared 'java_lang_ref_Reference'.
Making the corresponding header (classfile/javaClasses.hpp) included would fix it.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257743: Minimal build on AArch64 failed with --disable-precompiled-headers

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1619/head:pull/1619
$ git checkout pull/1619

[bridgekeeper]

👋 Welcome back shqking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shqking The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b304931)

[shipilev]

Looks good and trivial.

Is this a new build failure? Can you pinpoint the commit after which it started to fail?

[openjdk]

@shqking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257743: Minimal build on AArch64 failed with --disable-precompiled-headers

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d6dd440: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows
• 2b4a423: 8255542: Attribute length of Module, ModulePackages and other attributes is ignored
• ca40267: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

Nevermind, I bisected myself, it is caused by JDK-8257563, added the link to JIRA.

[shqking]

/integrate

[openjdk]

@shqking
Your change (at version b304931) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

@shipilev @shqking Since your change was applied there have been 3 commits pushed to the master branch:

• d6dd440: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows
• 2b4a423: 8255542: Attribute length of Module, ModulePackages and other attributes is ignored
• ca40267: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)

Your commit was automatically rebased without conflicts.

Pushed as commit af6b7f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[shqking]

Yes. It is indeed JDK-8257563. @shipilev Thanks a lot.