Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318124: JFR: Rewrite instrumentation to use Class-File API #16195

Closed
wants to merge 3 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Oct 15, 2023

Hi,

Could I have a review of an enhancement that replaces the use of ASM with the new Class-File API. This change only deals with bytecode that writes event data into buffers. Bytecode transformations carried out by classes in jdk.jfr.internal.intrument package are kept as is. Plan is to try to replace those with events in java.base.

To simplify the review process, I have tried to keep the code in the classes EventInstrumentation and EventClassBuilder similar to what existed before. Further refactorizations may happen at a later stage.

Testing: tier1-3 + jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318124: JFR: Rewrite instrumentation to use Class-File API (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16195/head:pull/16195
$ git checkout pull/16195

Update a local copy of the PR:
$ git checkout pull/16195
$ git pull https://git.openjdk.org/jdk.git pull/16195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16195

View PR using the GUI difftool:
$ git pr show -t 16195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16195.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@egahlin egahlin changed the title 8318124: JFR: Rewrite instrumentation to use the Class-File API 8318124: JFR: Rewrite instrumentation to use Class-File API Oct 15, 2023
@openjdk
Copy link

openjdk bot commented Oct 15, 2023

@egahlin The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Oct 15, 2023
@egahlin egahlin marked this pull request as ready for review October 15, 2023 22:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 15, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318124: JFR: Rewrite instrumentation to use Class-File API

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2023
@egahlin
Copy link
Member Author

egahlin commented Oct 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

Going to push as commit 69c0ae2.
Since your change was applied there have been 130 commits pushed to the master branch:

  • c1aeac7: 8318445: More broken bailout chains in C2
  • d888b26: 8318071: IgnoreUnrecognizedVMOptions flag still causes failure in ArchiveHeapTestClass
  • bea2d48: 8312475: org.jline.util.PumpReader signed byte problem
  • 9f767aa: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
  • bd22d23: 8318027: Support alternative name to jdk.internal.vm.compiler
  • c2efd77: 8295795: hsdis does not build with binutils 2.39+
  • 99de9bb: 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039
  • 704c6ea: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
  • 7c0a828: 8318649: G1: Remove unimplemented HeapRegionRemSet::add_code_root_locked
  • ff5c5b6: 8318643: +UseTransparentHugePages must enable +UseLargePages
  • ... and 120 more: https://git.openjdk.org/jdk/compare/01ea1eff66e43f106640ecfd19fadf2c8245a1ad...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2023
@openjdk openjdk bot closed this Oct 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@egahlin Pushed as commit 69c0ae2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
4 participants