8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2

[dougxc]

There's extra logic in the CompileBroker for waiting for blocking JVMCI compilations to try and prevent deadlock (JDK-8148507). However, this is not relevant for libgraal which does not run Java code that can be accessing locks used by other threads.

However, over time, this logic was extended to unblock a blocking compilation when a libgraal internal deadlock is detected. It turns out that this hides deadlocks or long compilations that should be solved in libgraal itself.

This PR makes blocking compilation with libgraal the same as blocking compilations for C1 and C2.

Testing: This has been tested for about 3 months against libgraal.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2 (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16197/head:pull/16197
$ git checkout pull/16197

Update a local copy of the PR:
$ git checkout pull/16197
$ git pull https://git.openjdk.org/jdk.git pull/16197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16197

View PR using the GUI difftool:
$ git pr show -t 16197

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16197.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (936ea891)

[TobiHartmann]

Looks reasonable to me.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2

Reviewed-by: thartmann, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 8c1bb2b: 8268916: Tests for AffirmTrust roots
• 2d38495: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
• 0d09168: 8312527: (ch) Re-examine use of sun.nio.ch.Invoker.myGroupAndInvokeCount
• 1a7fd5d: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS
• eb7d972: 8308659: Use CSS scroll-margin instead of flexbox layout in API documentation
• 7028fb9: 8317975: [JVMCI] assert(pointee != nullptr) failed: invariant
• 36993ae: 8316918: Optimize conversions duplicated across phi nodes
• 668d4b0: 8318154: Improve stability of WheelModifier.java test
• a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• a27fc7e: 8317994: Serial: Use SerialHeap in generation
• ... and 4 more: https://git.openjdk.org/jdk/compare/77d40ce166d665020a134f95e51fb9826a6ccf9b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 5521560.
Since your change was applied there have been 19 commits pushed to the master branch:

• e4329a8: 8317696: Fix compilation with clang-16
• 504b0bd: 8318078: ADLC: pass ASSERT and PRODUCT flags
• 7b39172: 8318086: [jvmci] RISC-V: Reuse target config from TargetDescription
• aed1e81: 8317285: Misspellings in hprof test lib
• 741ae06: 8313613: Use JUnit in langtools/lib tests
• 8c1bb2b: 8268916: Tests for AffirmTrust roots
• 2d38495: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
• 0d09168: 8312527: (ch) Re-examine use of sun.nio.ch.Invoker.myGroupAndInvokeCount
• 1a7fd5d: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS
• eb7d972: 8308659: Use CSS scroll-margin instead of flexbox layout in API documentation
• ... and 9 more: https://git.openjdk.org/jdk/compare/77d40ce166d665020a134f95e51fb9826a6ccf9b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 5521560.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.