Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253253: Binutils tar ball extension update to gz #162

Closed
wants to merge 1 commit into from

Conversation

junyuan-z
Copy link
Contributor

@junyuan-z junyuan-z commented Sep 15, 2020

Our infra team found this error when building DevKit with GCC 4.9.2. The binutils version is 2.25, and an *.xz doesn't exist on https://ftp.gnu.org/pub/gnu/binutils. Hence, we would like to submit a PR to update *.xz to *.gz.

We have confirmed that *.gz exists for all binutil version.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253253: Binutils tar ball extension update to gz

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/162/head:pull/162
$ git checkout pull/162

The existing binutils url does not work for `GCC 4.9.2` devkit because of `binutils-2.25` from `http://ftp.gnu.org/pub/gnu/binutils` does not contain `tar.xz` file.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back junyzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@junyzheng The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 15, 2020
@junyuan-z junyuan-z changed the title Fix linux GCC 4.9.2 devkit binutils url error 8253253: Binutils tar ball extension update to gz Sep 16, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

@erikj79
Copy link
Member

erikj79 commented Sep 16, 2020

The change is ok, but why would you need such an old devkit? We build with gcc 9.2 and are in the process of upgrading to 10.2. We have been lax with removing old configs for devkit generation.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@junyzheng This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253253: Binutils tar ball extension update to gz

Reviewed-by: erikj
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 76 commits pushed to the master branch:

  • 388c8f2: 8253348: Remove unimplemented JNIHandles::initialize
  • bca9e55: 8253167: ARM32 builds fail after JDK-8247910
  • cc7521c: 8252199: Reimplement support of Type 1 fonts without MappedByteBuffer
  • 3d88d38: 8252070: Some platform-specific BLIT optimizations are not effective
  • 83b0537: 8253291: bug7072653.java still failed "Popup window height ... is wrong"
  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • ... and 66 more: https://git.openjdk.java.net/jdk/compare/af8c678038c2a4788e287793bacdf1048634f3bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 388c8f2538744c0ef328861c04f6e251500e8adc.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@junyuan-z
Copy link
Contributor Author

We only use the GCC 4.9.2 for jdk8u. The openjdk/jdk repository's devkit contains all devkits that support older jdk. So we can just use this file to build all the devkits instead of pulling devkits from jdk8u and jdk11u. I also notice newer code always contains devkit from older code. jdk contains (gcc 9, 7, 8 4), jdk11u contains (gcc 7, 4), and jdk8u contains (gcc 4). But I will abandon this PR and change our workflow if outdated devkit will be eventually removed from openjdk/jdk repository.

@erikj79
Copy link
Member

erikj79 commented Sep 16, 2020

Ah, I see. I would say that the intention is not to keep the latest mainline devkit generation scripts updated to support all older update releases, but I can see how it could look that way given how we have so far not really deleted older configs.

@junyuan-z
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 17, 2020
@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@junyzheng
Your change (at version eb1c9d3) is now ready to be sponsored by a Committer.

@junyuan-z
Copy link
Contributor Author

I will check in this code just in case people are going to use this script to generate GCC 4.9.2 devkit.

@shipilev
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Sep 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Sep 21, 2020
@openjdk
Copy link

openjdk bot commented Sep 21, 2020

@shipilev @junyzheng Since your change was applied there have been 76 commits pushed to the master branch:

  • 388c8f2: 8253348: Remove unimplemented JNIHandles::initialize
  • bca9e55: 8253167: ARM32 builds fail after JDK-8247910
  • cc7521c: 8252199: Reimplement support of Type 1 fonts without MappedByteBuffer
  • 3d88d38: 8252070: Some platform-specific BLIT optimizations are not effective
  • 83b0537: 8253291: bug7072653.java still failed "Popup window height ... is wrong"
  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • ... and 66 more: https://git.openjdk.java.net/jdk/compare/af8c678038c2a4788e287793bacdf1048634f3bf...master

Your commit was automatically rebased without conflicts.

Pushed as commit fdce055.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants