New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253253: Binutils tar ball extension update to gz #162
Conversation
The existing binutils url does not work for `GCC 4.9.2` devkit because of `binutils-2.25` from `http://ftp.gnu.org/pub/gnu/binutils` does not contain `tar.xz` file.
|
@junyzheng The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
The change is ok, but why would you need such an old devkit? We build with gcc 9.2 and are in the process of upgrading to 10.2. We have been lax with removing old configs for devkit generation. |
@junyzheng This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 76 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.
|
We only use the GCC 4.9.2 for jdk8u. The openjdk/jdk repository's devkit contains all devkits that support older jdk. So we can just use this file to build all the devkits instead of pulling devkits from jdk8u and jdk11u. I also notice newer code always contains devkit from older code. jdk contains (gcc 9, 7, 8 4), jdk11u contains (gcc 7, 4), and jdk8u contains (gcc 4). But I will abandon this PR and change our workflow if outdated devkit will be eventually removed from openjdk/jdk repository. |
Ah, I see. I would say that the intention is not to keep the latest mainline devkit generation scripts updated to support all older update releases, but I can see how it could look that way given how we have so far not really deleted older configs. |
/integrate |
@junyzheng |
I will check in this code just in case people are going to use this script to generate GCC 4.9.2 devkit. |
/sponsor |
@shipilev @junyzheng Since your change was applied there have been 76 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit fdce055. |
Our infra team found this error when building DevKit with GCC 4.9.2. The binutils version is 2.25, and an *.xz doesn't exist on https://ftp.gnu.org/pub/gnu/binutils. Hence, we would like to submit a PR to update *.xz to *.gz.
We have confirmed that *.gz exists for all binutil version.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/162/head:pull/162
$ git checkout pull/162