Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8315457 Implement JEP 459: String Templates (Second Preview) #16202

Closed
wants to merge 9 commits into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Oct 16, 2023

Update String Templates for a second preview. With the addition of

  • Expression type and throws are determined from the process method of the processor type and not the processor type.

  • Qualified STR and RAW are treated the same as unqualified STR and RAW .

  • Raw (generic) process types are no longer an error.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315457: Implement JEP 459: String Templates (Second Preview) (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16202/head:pull/16202
$ git checkout pull/16202

Update a local copy of the PR:
$ git checkout pull/16202
$ git pull https://git.openjdk.org/jdk.git pull/16202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16202

View PR using the GUI difftool:
$ git pr show -t 16202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16202.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2023

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@JimLaskey The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • i18n
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 16, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2023

@wangweij
Copy link
Contributor

/label remove security

@openjdk openjdk bot removed the security security-dev@openjdk.org label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@wangweij
The security label was successfully removed.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javac changes look reasonable to me. Added some mostly minor comments.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315457: Implement JEP 459: String Templates (Second Preview)

Reviewed-by: jlahoda, alanb, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 5522656: 8317834: java/lang/Thread/IsAlive.java timed out
  • 9194d2c: 8317357: Update links in building.md to use https rather than http
  • 368e4f6: 8315801: [PPC64] JNI code should be more similar to the Panama implementation
  • 8ec6b8d: 8319876: Reduce memory consumption of VM_ThreadDump::doit
  • bbf52e0: 8319897: Move StackWatermark handling out of LockStack::contains
  • 129c470: 8311932: Suboptimal compiled code of nested loop over memory segment
  • 369bbec: 8319896: Remove monitor deflation from final audit
  • 1588dd9: 8319567: Update java/lang/invoke tests to support vm flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2023
@@ -419,18 +419,21 @@ public interface JavaLangAccess {

/**
* Get the coder for the supplied character.
* @since 21
*/
@PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can drop both @since and @PreviewFeature from these methods. This in an internal interface, used for shared secrets, there is a lot of churn in JLA in each release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 9, 2023
@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@JimLaskey This pull request has not yet been marked as ready for integration.

@JimLaskey JimLaskey changed the title JDK-8315457 Implementation of String Templates (Second Preview) JDK-8315457 Implement JEP 459: String Templates (Second Preview) Nov 17, 2023
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2023
@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

Going to push as commit 9902d2e.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 5522656: 8317834: java/lang/Thread/IsAlive.java timed out
  • 9194d2c: 8317357: Update links in building.md to use https rather than http
  • 368e4f6: 8315801: [PPC64] JNI code should be more similar to the Panama implementation
  • 8ec6b8d: 8319876: Reduce memory consumption of VM_ThreadDump::doit
  • bbf52e0: 8319897: Move StackWatermark handling out of LockStack::contains
  • 129c470: 8311932: Suboptimal compiled code of nested loop over memory segment
  • 369bbec: 8319896: Remove monitor deflation from final audit
  • 1588dd9: 8319567: Update java/lang/invoke tests to support vm flags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2023
@openjdk openjdk bot closed this Nov 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@JimLaskey Pushed as commit 9902d2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
5 participants