JDK-8318176: C2: dont assert in ~GraphKit if compilation had been interrupted

[tstuefe]

If compilation had been interrupted, which may have happened e.g. due to reaching the node limit check, the using code may not have called GraphKit::transfer_exceptions_into_jvms() yet; in that case, we should not assert.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318176: C2: dont assert in ~GraphKit if compilation had been interrupted (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16203/head:pull/16203
$ git checkout pull/16203

Update a local copy of the PR:
$ git checkout pull/16203
$ git pull https://git.openjdk.org/jdk.git pull/16203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16203

View PR using the GUI difftool:
$ git pr show -t 16203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16203.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c45707f1)

[TobiHartmann]

Couldn't you just call GraphKit::failing()?

[tstuefe]

Possibly. I also realized this can be merged with JDK-8318183 (#16205), so I close this PR and fix the graphkit dtor over there.