8318180: Memory model reference from foreign package-info is broken

[mcimadamore]

This PR fixes a wrong reference to the JLS memory model section.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318180: Memory model reference from foreign package-info is broken (Bug - P4)

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16204/head:pull/16204
$ git checkout pull/16204

Update a local copy of the PR:
$ git checkout pull/16204
$ git pull https://git.openjdk.org/jdk.git pull/16204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16204

View PR using the GUI difftool:
$ git pr show -t 16204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16204.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0ab468c0)

[mcimadamore]

The broken reference seems to have originated from a bogus edit to a section that used to be present:

* @apiNote The normal Java Object access control, guarantees and constraints, for example stated in
 * {@jls 6.6} and {@jls 10.4}, do not apply when accessing native memory segments as these segments are
 * backed by off-heap regions of memory.

Accidentally, normal Java Object access control, guarantees and constraints, was replaced to reference memory model (following a CSR comment). But the old JLS reference stayed, leading to this issue.

We could, if desired, also keep the old references (and text!) too - but IMHO it is a bit confusing to be talking about access control when mentioning access to off-heap memory, so maybe it would be better to leave those out?

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318180: Memory model reference from foreign package-info is broken

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• aed1e81: 8317285: Misspellings in hprof test lib
• 741ae06: 8313613: Use JUnit in langtools/lib tests
• 8c1bb2b: 8268916: Tests for AffirmTrust roots
• 2d38495: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
• 0d09168: 8312527: (ch) Re-examine use of sun.nio.ch.Invoker.myGroupAndInvokeCount
• 1a7fd5d: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS
• eb7d972: 8308659: Use CSS scroll-margin instead of flexbox layout in API documentation
• 7028fb9: 8317975: [JVMCI] assert(pointee != nullptr) failed: invariant
• 36993ae: 8316918: Optimize conversions duplicated across phi nodes
• 668d4b0: 8318154: Improve stability of WheelModifier.java test
• ... and 13 more: https://git.openjdk.org/jdk/compare/7cb2e6d65b517b638a584149560a2ff9cc56c3b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JornVernee]

We could, if desired, also keep the old references (and text!) too - but IMHO it is a bit confusing to be talking about access control when mentioning access to off-heap memory, so maybe it would be better to leave those out?

I don't see how a reference to access control would be useful here. Leave it out, IMO.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit b2b8db6.
Since your change was applied there have been 31 commits pushed to the master branch:

• 5bd1052: 8317317: G1: Make TestG1RemSetFlags use createTestJvm
• c64bd3d: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
• 6ee6171: 8317347: Parallel: Make TestInitialTenuringThreshold use createTestJvm
• 7ca0ae9: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
• 5521560: 8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2
• e4329a8: 8317696: Fix compilation with clang-16
• 504b0bd: 8318078: ADLC: pass ASSERT and PRODUCT flags
• 7b39172: 8318086: [jvmci] RISC-V: Reuse target config from TargetDescription
• aed1e81: 8317285: Misspellings in hprof test lib
• 741ae06: 8313613: Use JUnit in langtools/lib tests
• ... and 21 more: https://git.openjdk.org/jdk/compare/7cb2e6d65b517b638a584149560a2ff9cc56c3b6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit b2b8db6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.