Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318240: [AIX] Cleaners.java test failure #16212

Closed
wants to merge 1 commit into from

Conversation

varada1110
Copy link
Contributor

@varada1110 varada1110 commented Oct 17, 2023

When the test sets the sun.security.jgss.native and sun.security.nativegss.debug as true, the test fails on AIX due to missing Kerberos GSS API dynamic library libgssapi_krb5.so

JBS Issue : JDK-8318240


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318240: [AIX] Cleaners.java test failure (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16212/head:pull/16212
$ git checkout pull/16212

Update a local copy of the PR:
$ git checkout pull/16212
$ git pull https://git.openjdk.org/jdk.git pull/16212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16212

View PR using the GUI difftool:
$ git pr show -t 16212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16212.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2023

👋 Welcome back varada1110! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@varada1110 The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 17, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@varada1110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318240: [AIX] Cleaners.java test failure

Reviewed-by: mbaesken, asteiner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 171 new commits pushed to the master branch:

  • bea2d48: 8312475: org.jline.util.PumpReader signed byte problem
  • 9f767aa: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
  • bd22d23: 8318027: Support alternative name to jdk.internal.vm.compiler
  • c2efd77: 8295795: hsdis does not build with binutils 2.39+
  • 99de9bb: 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039
  • 704c6ea: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
  • 7c0a828: 8318649: G1: Remove unimplemented HeapRegionRemSet::add_code_root_locked
  • ff5c5b6: 8318643: +UseTransparentHugePages must enable +UseLargePages
  • fc29a2e: 8318082: ConcurrentModificationException from IndexWriter
  • 729f4c5: 8318507: G1: Improve remset clearing for humongous candidates
  • ... and 161 more: https://git.openjdk.org/jdk/compare/2edf9c3f1e968779c6e92b3e25d780db68ace5cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2023
@varada1110
Copy link
Contributor Author

Thank you @MBaesken & @ansteiner
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@varada1110
Your change (at version 3311a50) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

Going to push as commit d4b7612.
Since your change was applied there have been 192 commits pushed to the master branch:

  • bf1a14e: 8316470: Incorrect error location for "invalid permits clause" depending on file order
  • 5224e97: 8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher
  • 9bfa082: 8318646: Integer#parseInt("") throws empty NumberFormatException message
  • 3f446c5: 8318528: Rename TestUnstructuredLocking test
  • 0baa9ec: 8318474: Fix memory reporter for thread_count
  • 4a16d11: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
  • a644670: 8318609: Upcall stubs should be smaller
  • e6f23a9: 8315024: Vector API FP reduction tests should not test for exact equality
  • fd332da: 8317289: javadoc fails with -sourcepath if module-info.java contains import statements
  • 6d3cb45: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
  • ... and 182 more: https://git.openjdk.org/jdk/compare/2edf9c3f1e968779c6e92b3e25d780db68ace5cc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2023
@openjdk openjdk bot closed this Oct 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@MBaesken @varada1110 Pushed as commit d4b7612.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants