Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8058176: [mlvm] tests should tolerate exceptions caused by code cache exhaustion #1622

Closed
wants to merge 2 commits into from

Conversation

@lepestock
Copy link
Contributor

@lepestock lepestock commented Dec 4, 2020

  1. Normalise meth/stress/compiler/i2c_c2i/Test.java to use MultiThreadedTest framework;
  2. Adjust MultiThreadedTest in order to accomodate the i2c_c2i test (add prepareThread method and logic);
  3. Add ThrowableTolerance and DefaultThrowableTolerance as ways to control what Throwables are accepted;
  4. Adjust MultiThreadedTest to catch Throwables and check if they are accepted;
  5. Adjust individual tests to catch possible Throwables and check if they are accepted;
  6. Un-problemlist the failing tests.

Testing: vmTestBase/vm/mlvm/meth/stress and vmTestBase/vm/mlvm/func tests run on macos-linux-windows in x64-debug configurations.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8058176: [mlvm] tests should tolerate exceptions caused by code cache exhaustion

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1622/head:pull/1622
$ git checkout pull/1622

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 4, 2020

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2020

@lepestock The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Dec 4, 2020
@lepestock lepestock changed the title 8058176: [mlvm] tests should tolerate exceptions caused by code cache exhaustion. 8058176: [mlvm] tests should tolerate exceptions caused by code cache exhaustion Dec 4, 2020
@openjdk openjdk bot added the rfr label Dec 4, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 4, 2020

Webrevs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 1, 2021

@lepestock This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 29, 2021

@lepestock This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Jan 29, 2021
@lepestock lepestock deleted the lepestock:JDK-8058176/public branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant