Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) #1624

Closed
wants to merge 20 commits into from
Closed

8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) #1624

wants to merge 20 commits into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Dec 4, 2020 •
edited by openjdk bot
Loading

Greetings,

please help review this enhancement to let JFR sample object allocations by default.

A description is provided in the JIRA issue.

Thanks
Markus

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)

Reviewers

Contributors

  • Jaroslav Bachorik <jbachorik@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1624/head:pull/1624
$ git checkout pull/1624

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2020

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 4, 2020
@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun
The core-libs label was successfully removed.

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun
The hotspot label was successfully removed.

@mgronlun
Copy link
Author

mgronlun commented Dec 4, 2020

/label hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun Unknown command contributer - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun Unknown command contributer - for a list of valid commands use /help.

@mgronlun
Copy link
Author

mgronlun commented Dec 4, 2020 •
edited
Loading

/label hotspot-jfr

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mgronlun
The hotspot-jfr label was successfully added.

@mgronlun mgronlun marked this pull request as ready for review December 4, 2020 18:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2020 •
edited
Loading

Webrevs

@mgronlun
Copy link
Author

mgronlun commented Dec 6, 2020

/label remove build hotspot-gc hotspot-jfr

@openjdk openjdk bot removed build build-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Dec 6, 2020
@openjdk
Copy link

openjdk bot commented Dec 6, 2020

@mgronlun
The build label was successfully removed.

The hotspot-gc label was successfully removed.

The hotspot-jfr label was successfully removed.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

20 similar comments
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully removed.

@mgronlun
Copy link
Author

/contributor add jbachorik

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun
Contributor Jaroslav Bachorik <jbachorik@openjdk.org> successfully added.

@mgronlun
Copy link
Author

/integrate

@openjdk openjdk bot closed this Dec 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mgronlun Since your change was applied there have been 106 commits pushed to the master branch:

  • 026b09c: 8257483: C2: Split immediate vector rotate from RotateLeftV and RotateRightV nodes
  • 0a0691e: 8257901: ZGC: Take virtual memory usage into account when sizing heap
  • 29ffffa: 8257997: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java again reports leaks after JDK-8257884
  • db5da96: 8257876: Avoid Reference.isEnqueued in tests
  • 4a839e9: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information
  • d93293f: 8256730: Code that uses Object.checkIndex() range checks doesn't optimize well
  • 869dcb6: 8257806: Optimize x86 allTrue and anyTrue vector mask operations of Vector API
  • 34650f5: 8257872: UL: -Xlog does not check number of options
  • 6847bbb: 8255918: XMLStreamFilterImpl constructor consumes XMLStreamException
  • d2f9e31: 8257638: Update usage of "type" terminology in javax.lang.model
  • ... and 96 more: https://git.openjdk.java.net/jdk/compare/86b65756cbebf1df422b11a72be6c9762b85a702...master

Your commit was automatically rebased without conflicts.

Pushed as commit 502a524.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@egahlin egahlin egahlin approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
5 participants
@mgronlun @Hin4t3n2D @magicus @jbachorik @egahlin