-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913 #16246
8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913 #16246
Conversation
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
@aivanov-jdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label client |
@aivanov-jdk |
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 71c99a0.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk Pushed as commit 71c99a0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to JDK-8259913 which is a specific bug for AWT menus in High DPI environment.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16246/head:pull/16246
$ git checkout pull/16246
Update a local copy of the PR:
$ git checkout pull/16246
$ git pull https://git.openjdk.org/jdk.git pull/16246/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16246
View PR using the GUI difftool:
$ git pr show -t 16246
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16246.diff
Webrev
Link to Webrev Comment