Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913 #16246

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Oct 18, 2023

Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to JDK-8259913 which is a specific bug for AWT menus in High DPI environment.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16246/head:pull/16246
$ git checkout pull/16246

Update a local copy of the PR:
$ git checkout pull/16246
$ git pull https://git.openjdk.org/jdk.git pull/16246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16246

View PR using the GUI difftool:
$ git pr show -t 16246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16246.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@aivanov-jdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@aivanov-jdk
Copy link
Member Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@aivanov-jdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ce8ebeb: 8317979: Use TZ database style abbreviations in the CLDR locale provider
  • ab13568: 8318029: Minor improvement to logging output in container at-requires
  • 278de7a: 8318458: Update javac and java manpages with restricted method options

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

Going to push as commit 71c99a0.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 2c23391: 8318101: Additional test cases for CSSAttributeEqualityBug
  • deadb9c: 8304684: Memory leak in DirectivesParser::set_option_flag
  • a03767c: 8318049: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN
  • 848ecc1: 8318538: Add a way to obtain a strided var handle from a layout
  • b07da3a: 8317819: Scope should reflect lifetime of underying resource (mainline)
  • 6f1d896: 8318510: Serial: Remove TenuredGeneration::block_size
  • 8f4ebd8: 8317920: JDWP-agent sends broken exception event with onthrow option
  • cd25d1a: 8318296: Move Space::initialize to ContiguousSpace
  • 744f206: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • 8099261: 8318489: Remove unused alignment_unit and alignment_offset
  • ... and 26 more: https://git.openjdk.org/jdk/compare/6fc35142315f1616fa35e415005c9483939c6920...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2023
@openjdk openjdk bot closed this Oct 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@aivanov-jdk Pushed as commit 71c99a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8318448-PopupMenuLocation.java-PL8259913 branch October 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants