Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field #16279

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Oct 19, 2023

Please review this PR which adjusts the specification of DateFormat.Field::getCalendarField to conform to the implementation.

getCalendarField() claims that it will return -1 if there is no corresponding Calendar constant.

Although the built-in DateFormat.Fields with no associated Calendar constant are created with a calendarField equal to -1, a subclass can create a DateFormat.Field with no associated Calendar constant with calendarField equal to anything.

The specification of getCalendarField() should be adjusted to reflect this. That is, a separate implementation may or may not return -1 if there is no associated Calendar constant.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8318035 to be approved

Issues

  • JDK-7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field (Bug - P4)
  • JDK-8318035: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16279/head:pull/16279
$ git checkout pull/16279

Update a local copy of the PR:
$ git checkout pull/16279
$ git pull https://git.openjdk.org/jdk.git pull/16279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16279

View PR using the GUI difftool:
$ git pr show -t 16279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16279.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 19, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 156 new commits pushed to the master branch:

  • 684b91e: 8315064: j.text.ChoiceFormat provides no specification on quoting behavior
  • 1740950: 8314901: AES-GCM interleaved implementation using AVX2 instructions
  • cc8f8da: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • 599560a: 8317635: Improve GetClassFields test to verify correctness of field order
  • 9cf334f: 8318383: Remove duplicated checks in os::get_native_stack() in posix implementation
  • defc7e0: 8318454: TestLayoutPaths broken on Big Endian platforms after JDK-8317837
  • 3c70f2c: 8318418: hsdis build fails with system binutils on Ubuntu
  • 15acf4b: 8318324: Drop redundant default methods from FFM API
  • 1a09835: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 47bb1a1: 8318415: Adjust describing comment of os_getChildren after 8315026
  • ... and 146 more: https://git.openjdk.org/jdk/compare/f61499c73fe03e2e3680d7f58a84183364c5c5ac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

Going to push as commit 4dfa379.
Since your change was applied there have been 187 commits pushed to the master branch:

  • 158293d: 8316030: Update Libpng to 1.6.40
  • a045258: 8209595: MonitorVmStartTerminate.java timed out
  • 2121575: 8318421: AbstractPipeline.sourceStageSpliterator() chases pointers needlessly
  • 200b5a2: 8318420: AbstractPipeline invokes overridden method in constructor
  • 5281499: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27
  • 8065233: 8318598: FFM stylistic cleanups
  • b1228de: 8314588: gc/metaspace/TestMetaspaceInitialization.java failed "assert(capacity_until_gc >= committed_bytes) failed: capacity_until_gc: 3145728 < committed_bytes: 3211264"
  • 5a97411: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics
  • 9144287: 8318601: Remove javadoc text about restricted methods
  • 4010642: 8077371: Binary files in JAXP test should be removed
  • ... and 177 more: https://git.openjdk.org/jdk/compare/f61499c73fe03e2e3680d7f58a84183364c5c5ac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2023
@openjdk openjdk bot closed this Oct 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@justin-curtis-lu Pushed as commit 4dfa379.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
2 participants