Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed #16291

Closed

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Oct 20, 2023

Please review this trivial problem listing change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16291/head:pull/16291
$ git checkout pull/16291

Update a local copy of the PR:
$ git checkout pull/16291
$ git pull https://git.openjdk.org/jdk.git pull/16291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16291

View PR using the GUI difftool:
$ git pr show -t 16291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16291.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8318482: problemlist compiler/codecache/CheckLargePages.java on Linux… 8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed Oct 20, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@mseledts To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 66d90d5: 8318107: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 4dfa379: 7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field
  • 158293d: 8316030: Update Libpng to 1.6.40
  • a045258: 8209595: MonitorVmStartTerminate.java timed out
  • 2121575: 8318421: AbstractPipeline.sourceStageSpliterator() chases pointers needlessly
  • 200b5a2: 8318420: AbstractPipeline invokes overridden method in constructor
  • 5281499: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2023
@mseledts
Copy link
Member Author

Thank you Leonid.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

Going to push as commit 77b2394.
Since your change was applied there have been 8 commits pushed to the master branch:

  • d3ebb4a: 8317373: Add Telia Root CA v2
  • 66d90d5: 8318107: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 4dfa379: 7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field
  • 158293d: 8316030: Update Libpng to 1.6.40
  • a045258: 8209595: MonitorVmStartTerminate.java timed out
  • 2121575: 8318421: AbstractPipeline.sourceStageSpliterator() chases pointers needlessly
  • 200b5a2: 8318420: AbstractPipeline invokes overridden method in constructor
  • 5281499: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2023
@openjdk openjdk bot closed this Oct 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@mseledts Pushed as commit 77b2394.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants