Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8318643: +UseTransparentHugePages must enable +UseLargePages #16302

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 23, 2023

Per contract, +UseTransparentHugePages implies +UseLargePages. That automatism was lost with JDK-8261894.

The fix is trivial.

Note that a regression test exists, (#15159), that's how I found this issue. But this regression test has been drifting in Review Limbo since August. It just needs a second review, @kstefanj already reviewed it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318643: +UseTransparentHugePages must enable +UseLargePages (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16302/head:pull/16302
$ git checkout pull/16302

Update a local copy of the PR:
$ git checkout pull/16302
$ git pull https://git.openjdk.org/jdk.git pull/16302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16302

View PR using the GUI difftool:
$ git pr show -t 16302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16302.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 23, 2023
@tstuefe tstuefe marked this pull request as ready for review October 23, 2023 06:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems trivial but I'm struggling to see where JDK-8261894 broke this. ??

@tstuefe
Copy link
Member Author

tstuefe commented Oct 23, 2023

Seems trivial but I'm struggling to see where JDK-8261894 broke this. ??

Thanks David!

It removed the last line in large_page_init():

  // Now determine the type of large pages to use:
  UseLargePages = os::Linux::setup_large_page_type(_large_page_size);

Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318643: +UseTransparentHugePages must enable +UseLargePages

Reviewed-by: sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • fc29a2e: 8318082: ConcurrentModificationException from IndexWriter
  • 729f4c5: 8318507: G1: Improve remset clearing for humongous candidates
  • 4eab39d: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
  • ffadd63: 8317868: Add @sealedGraph to MethodHandleDesc and descendants

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Oct 23, 2023

Thanks @kstefanj and @dholmes-ora

Since its trivial and all checks are green, I'll push.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

Going to push as commit ff5c5b6.
Since your change was applied there have been 4 commits pushed to the master branch:

  • fc29a2e: 8318082: ConcurrentModificationException from IndexWriter
  • 729f4c5: 8318507: G1: Improve remset clearing for humongous candidates
  • 4eab39d: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
  • ffadd63: 8317868: Add @sealedGraph to MethodHandleDesc and descendants

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2023
@openjdk openjdk bot closed this Oct 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tstuefe Pushed as commit ff5c5b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants