8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

[viktorklang-ora]

Resolves a visibility issue in SubmissionPublisher by making the waiter member of BufferedSubscription volatile.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Contributors

• Jaikiran Pai <jpai@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16313/head:pull/16313
$ git checkout pull/16313

Update a local copy of the PR:
$ git checkout pull/16313
$ git pull https://git.openjdk.org/jdk.git pull/16313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16313

View PR using the GUI difftool:
$ git pr show -t 16313

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16313.diff

Webrev

Link to Webrev Comment

[viktorklang-ora]

/contributor add @jaikiran

[viktorklang-ora]

Discussed this change with @DougLea

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora
Contributor Jaikiran Pai <jpai@openjdk.org> successfully added.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ce016455)

[DougLea]

Yes, looks good to me.

[viktorklang-ora]

@AlanBateman @stuart-marks Does any of you have any cycles to review this one-word PR? :)

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

Co-authored-by: Jaikiran Pai <jpai@openjdk.org>
Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 4a16d11: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
• a644670: 8318609: Upcall stubs should be smaller
• e6f23a9: 8315024: Vector API FP reduction tests should not test for exact equality
• fd332da: 8317289: javadoc fails with -sourcepath if module-info.java contains import statements
• 6d3cb45: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
• cb383c0: 8318587: refresh libraries cache on AIX in print_vm_info
• 4bfe226: 8310031: Parallel: Implement better work distribution for large object arrays in old gen
• 08f7914: 8305753: Allow JIT compilation for -Xshare:dump
• 728b858: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses
• eb59167: 8318691: runtime/CompressedOops/CompressedClassPointersEncodingScheme.java fails with release VMs
• ... and 6 more: https://git.openjdk.org/jdk/compare/bea2d48696ee2c213e475ca3aa3aa9c412b91089...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[viktorklang-ora]

/integrate

[openjdk]

@viktorklang-ora
Your change (at version ce01645) is now ready to be sponsored by a Committer.

[AlanBateman]

/sponsor

[openjdk]

Going to push as commit 5224e97.
Since your change was applied there have been 19 commits pushed to the master branch:

• 9bfa082: 8318646: Integer#parseInt("") throws empty NumberFormatException message
• 3f446c5: 8318528: Rename TestUnstructuredLocking test
• 0baa9ec: 8318474: Fix memory reporter for thread_count
• 4a16d11: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
• a644670: 8318609: Upcall stubs should be smaller
• e6f23a9: 8315024: Vector API FP reduction tests should not test for exact equality
• fd332da: 8317289: javadoc fails with -sourcepath if module-info.java contains import statements
• 6d3cb45: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
• cb383c0: 8318587: refresh libraries cache on AIX in print_vm_info
• 4bfe226: 8310031: Parallel: Implement better work distribution for large object arrays in old gen
• ... and 9 more: https://git.openjdk.org/jdk/compare/bea2d48696ee2c213e475ca3aa3aa9c412b91089...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman @viktorklang-ora Pushed as commit 5224e97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.