8318222: RISC-V: C2 CmpU3

[Hamlin-Li]

Hi,
Can you review the change to add intrinsic for CmpU3 and CmpUL3?
Thanks!

Test

functionality

pass jtreg test:
jdk/java/lang/Long/Unsigned.java, jdk/java/lang/Integer/Unsigned.java

performance

Long

before:
Benchmark (size) Mode Cnt Score Error Units
Longs.compareUnsignedDirect 500 avgt 5 1454.789 ± 129.557 ns/op
Longs.compareUnsignedIndirect 500 avgt 5 1410.146 ± 120.017 ns/op

after:
Benchmark (size) Mode Cnt Score Error Units
Longs.compareUnsignedDirect 500 avgt 5 1286.129 ± 8.441 ns/op
Longs.compareUnsignedIndirect 500 avgt 5 993.490 ± 0.840 ns/op

Integer

before:
Benchmark (size) Mode Cnt Score Error Units
Integers.compareUnsignedDirect 500 avgt 5 1611.753 ± 0.700 ns/op
Integers.compareUnsignedIndirect 500 avgt 5 1775.093 ± 1.520 ns/op

after:
Benchmark (size) Mode Cnt Score Error Units
Integers.compareUnsignedDirect 500 avgt 5 1159.351 ± 0.601 ns/op
Integers.compareUnsignedIndirect 500 avgt 5 776.185 ± 0.924 ns/op

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8318222: RISC-V: C2 CmpU3 (Sub-task - P4)
• JDK-8318223: RISC-V: C2 CmpUL3 (Sub-task - P4)

Reviewers

• Robbin Ehn (@robehn - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16314/head:pull/16314
$ git checkout pull/16314

Update a local copy of the PR:
$ git checkout pull/16314
$ git pull https://git.openjdk.org/jdk.git pull/16314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16314

View PR using the GUI difftool:
$ git pr show -t 16314

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16314.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d064a1cc)

[robehn]

Thank you, looks good!

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318222: RISC-V: C2 CmpU3
8318223: RISC-V: C2 CmpUL3

Reviewed-by: rehn, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• d1077d6: 8316046: x64 platforms unecessarily save xmm16-31 when UseAVX >= 3
• 21d8a47: 8318701: Fix copyright year
• d4b7612: 8318240: [AIX] Cleaners.java test failure
• bf1a14e: 8316470: Incorrect error location for "invalid permits clause" depending on file order
• 5224e97: 8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher
• 9bfa082: 8318646: Integer#parseInt("") throws empty NumberFormatException message
• 3f446c5: 8318528: Rename TestUnstructuredLocking test
• 0baa9ec: 8318474: Fix memory reporter for thread_count
• 4a16d11: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
• a644670: 8318609: Upcall stubs should be smaller
• ... and 14 more: https://git.openjdk.org/jdk/compare/bea2d48696ee2c213e475ca3aa3aa9c412b91089...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

LGTM. May I ask on which platform was the JMH tested?
Also I think it's safer to perform some regression tests like tier1-3.

[Hamlin-Li]

LGTM. May I ask on which platform was the JMH tested?

It's StarFive VisionFive 2 v1.3B

Also I think it's safer to perform some regression tests like tier1-3.

Thanks for reminding, I've run the hotspot compiler tests, and related jdk tests found by grep -nr test/jdk -we Long.compareUnsigned -we Integer.compareUnsigned

[Hamlin-Li]

/solves JDK-8318223
/integrate

Thanks @robehn @RealFYang for your revewing!

[openjdk]

@Hamlin-Li
Adding additional issue to solves list: 8318223: RISC-V: C2 CmpUL3.

[openjdk]

Going to push as commit f9795d0.
Since your change was applied there have been 24 commits pushed to the master branch:

• d1077d6: 8316046: x64 platforms unecessarily save xmm16-31 when UseAVX >= 3
• 21d8a47: 8318701: Fix copyright year
• d4b7612: 8318240: [AIX] Cleaners.java test failure
• bf1a14e: 8316470: Incorrect error location for "invalid permits clause" depending on file order
• 5224e97: 8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher
• 9bfa082: 8318646: Integer#parseInt("") throws empty NumberFormatException message
• 3f446c5: 8318528: Rename TestUnstructuredLocking test
• 0baa9ec: 8318474: Fix memory reporter for thread_count
• 4a16d11: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
• a644670: 8318609: Upcall stubs should be smaller
• ... and 14 more: https://git.openjdk.org/jdk/compare/bea2d48696ee2c213e475ca3aa3aa9c412b91089...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit f9795d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.