Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318479: [jmh] the test security.CacheBench failed for multiple threads run #16315

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Oct 23, 2023

Remove the hardcoded maximum heap size.

Verified that the benchmark now passes with 100 threads given sufficient heap:

make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g"

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318479: [jmh] the test security.CacheBench failed for multiple threads run (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16315/head:pull/16315
$ git checkout pull/16315

Update a local copy of the PR:
$ git checkout pull/16315
$ git pull https://git.openjdk.org/jdk.git pull/16315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16315

View PR using the GUI difftool:
$ git pr show -t 16315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16315.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2023

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8318479 8318479: [jmh] the test security.CacheBench failed for multiple threads run Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@djelinski The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 23, 2023
@djelinski djelinski marked this pull request as ready for review October 23, 2023 16:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

@seanjmullan
Copy link
Member

Looks ok to me but I would request a review from @cl4es since he introduced the limit in #9189.

@cl4es
Copy link
Member

cl4es commented Nov 9, 2023

Looks ok to me but I would request a review from @cl4es since he introduced the limit in #9189.

The -Xmx1g was there before #9189 (I only modified the line to add value = 3 to reduce number of forks).

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318479: [jmh] the test security.CacheBench  failed for multiple threads run

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 257 new commits pushed to the master branch:

  • 115b074: 8319944: Remove DynamicDumpSharedSpaces
  • c0507af: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)
  • 3684b4b: 8306116: Update CLDR to Version 44.0
  • 88ccd64: 8296250: Update ICU4J to Version 74.1
  • 03db828: 8319650: Improve heap dump performance with class metadata caching
  • b41b00a: 8319820: Use unnamed variables in the FFM implementation
  • 4d650fe: 8319704: LogTagSet::set_output_level() should not accept NULL as LogOutput
  • 6f863b2: 8318636: Add jcmd to print annotated process memory map
  • e035637: 8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX
  • 50f41d6: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node
  • ... and 247 more: https://git.openjdk.org/jdk/compare/bea2d48696ee2c213e475ca3aa3aa9c412b91089...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2023
@djelinski
Copy link
Member Author

I introduced the limit originally; I think I needed it because the default limit on my machine was too low to run the benchmark with the largest cache size.

@djelinski
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit 1535528.
Since your change was applied there have been 266 commits pushed to the master branch:

  • 95bd92a: 8210807: Printing a JTable with a JScrollPane prints table without rows populated
  • 21cda19: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet
  • b120a05: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
  • 7df73a2: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K)
  • 07eaea8: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
  • fe0ccdf: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException
  • 1802cb5: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle
  • d992033: 8317562: [JFR] Compilation queue statistics
  • 965ae72: 8319753: Duration javadoc has "period" instead of "duration" in several places
  • 115b074: 8319944: Remove DynamicDumpSharedSpaces
  • ... and 256 more: https://git.openjdk.org/jdk/compare/bea2d48696ee2c213e475ca3aa3aa9c412b91089...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@djelinski Pushed as commit 1535528.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the cachebench-opts branch November 14, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants