8318100: Remove redundant check for Metal support

[jayathirthrao]

We have updated minimum macOS version on which JDK can be used to macOS 11 and we have check to enable metal pipeline only when macOS version is >=10.14.

Since minimum macOS version is updated we don't need this check now.
Removed redundant check and ran all clientlibs tests on CI for verification.
Also ran a sample program with different combination of sun.java2d.metal and sun.java2d.opengl flags and i see that appropriate pipeline is getting selected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318100: Remove redundant check for Metal support (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Damon Nguyen (@DamonGuy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16316/head:pull/16316
$ git checkout pull/16316

Update a local copy of the PR:
$ git checkout pull/16316
$ git pull https://git.openjdk.org/jdk.git pull/16316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16316

View PR using the GUI difftool:
$ git pr show -t 16316

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16316.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jayathirthrao The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2f4bbd5c)

[mrserb]

Just wonder how the the java will work on 10.xx after JDK-8317970 integration, it will fail to start?

[openjdk]

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318100: Remove redundant check for Metal support

Reviewed-by: prr, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 9c819fd: 8318051: Duration.between uses exceptions for control flow
• 1ddf826: 8316964: Security tools should not call System.exit
• 1f2a80b: 8318306: java/util/Arrays/Sorting.java fails with "Array is not sorted at 8228-th position: 8251.0 and 8153.0"
• 1165037: 8318569: Add getter methods for Locale and Patterns in ListFormat
• 6f35274: 8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp
• e272098: 8318160: javac does not reject private method reference with type-variable receiver
• 54c613a: 8318693: Fix rendering for code blocks nested under list items in building.md
• e67550c: 8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0
• 8879c78: 8317689: [JVMCI] include error message when CreateJavaVM in libgraal fails
• f9795d0: 8318222: RISC-V: C2 CmpU3
• ... and 35 more: https://git.openjdk.org/jdk/compare/ffadd635759d0898cd108f5fe5fe3a4a3de91763...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonGuy]

Changes look reasonable to me. Test results look good too

[jayathirthrao]

Just wonder how the the java will work on 10.xx after JDK-8317970 integration, it will fail to start?

Yes. Last update to macOS Catalina was in Mid 2022 as mentioned at https://bugs.openjdk.org/browse/JDK-8317970.

[jayathirthrao]

/integrate

[openjdk]

Going to push as commit 5ce718e.
Since your change was applied there have been 46 commits pushed to the master branch:

• f1dfdc1: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild
• 9c819fd: 8318051: Duration.between uses exceptions for control flow
• 1ddf826: 8316964: Security tools should not call System.exit
• 1f2a80b: 8318306: java/util/Arrays/Sorting.java fails with "Array is not sorted at 8228-th position: 8251.0 and 8153.0"
• 1165037: 8318569: Add getter methods for Locale and Patterns in ListFormat
• 6f35274: 8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp
• e272098: 8318160: javac does not reject private method reference with type-variable receiver
• 54c613a: 8318693: Fix rendering for code blocks nested under list items in building.md
• e67550c: 8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0
• 8879c78: 8317689: [JVMCI] include error message when CreateJavaVM in libgraal fails
• ... and 36 more: https://git.openjdk.org/jdk/compare/ffadd635759d0898cd108f5fe5fe3a4a3de91763...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jayathirthrao Pushed as commit 5ce718e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.