8318646: Integer#parseInt("") throws empty NumberFormatException message

[rgiulietti]

Please review this simple fix to restore the original exception message that existed before 16050.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318646: Integer#parseInt("") throws empty NumberFormatException message (Enhancement - P4)

Reviewers

• Claes Redestad (@cl4es - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)
• Uwe Schindler (@uschindler - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16320/head:pull/16320
$ git checkout pull/16320

Update a local copy of the PR:
$ git checkout pull/16320
$ git pull https://git.openjdk.org/jdk.git pull/16320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16320

View PR using the GUI difftool:
$ git pr show -t 16320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16320.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5fff5adc)
• 00: Full (ea60758b)

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318646: Integer#parseInt("") throws empty NumberFormatException message

Reviewed-by: redestad, alanb, bpb, darcy, uschindler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 1b15011: 8318476: Add resource consumption note to BigInteger and BigDecimal
• 5ba9705: 8318485: Narrow klass shift should be zero if encoding range extends to 0x1_0000_0000

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

+1

[rgiulietti]

@uschindler You may want to make the Lucene tests more robust by making them immune to exception messages contents.

But thanks for trying out the EA releases on important libraries like Lucene ;-) It is important to have early feedback to gain more information before shipping the GA release.

[rgiulietti]

/integrate

[openjdk]

Going to push as commit 9bfa082.
Since your change was applied there have been 14 commits pushed to the master branch:

• 3f446c5: 8318528: Rename TestUnstructuredLocking test
• 0baa9ec: 8318474: Fix memory reporter for thread_count
• 4a16d11: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
• a644670: 8318609: Upcall stubs should be smaller
• e6f23a9: 8315024: Vector API FP reduction tests should not test for exact equality
• fd332da: 8317289: javadoc fails with -sourcepath if module-info.java contains import statements
• 6d3cb45: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
• cb383c0: 8318587: refresh libraries cache on AIX in print_vm_info
• 4bfe226: 8310031: Parallel: Implement better work distribution for large object arrays in old gen
• 08f7914: 8305753: Allow JIT compilation for -Xshare:dump
• ... and 4 more: https://git.openjdk.org/jdk/compare/8d9a4b43f4fff30fd217dab2c224e641cb913c18...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit 9bfa082.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[uschindler]

@uschindler You may want to make the Lucene tests more robust by making them immune to exception messages contents.

But thanks for trying out the EA releases on important libraries like Lucene ;-) It is important to have early feedback to gain more information before shipping the GA release.

Thanks for this. Actually this was a bad example. This was just test code, so I will more or less only remove the message check. In that case it would be enough to check for the NumberFormatException. I will provide a fix for this.

This is a very old test from a not so well-maintained module. Anyways it helped a bit to make the code more clean, because the NumberFormatException is now generated in the same way everywhere which makes it more consistent.

I mainly openend the iusse to inform you about that incompatibility because the exception message looks the same since very early java versions. So suddenly chaging it might bring others into the same situation like we were. I agree the spec does not enforce a message, but a more helpful message is always better than the completely empty one. So I would say, this PR is just a cleanup so "enhancement" as said by Alan Bateman is a good categorization.

Thanks for the quick fix. But I will fix the issue in Lucene, too!

P.S.: At other code we do not rely on exception messages. In recent code of MemorySegment we have some ambiguity with IllegalStateException when the scope of a memory segment was closed. I refused to look into the exception message and instead of parsing mesage - when catching exception, it now checks the memorysegment's scope was closed and only then convert the exception to a Lucene "AlreadyClosedException". In all other cases it is rethrowing the original exception. With exception messages you would have to look for some text string in them which is fragile. See this example: apache/lucene#12707