Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter #16325

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 23, 2023

Add an implNote about the minBufferCap parameter of the three-arg Channels.newWriter and slightly tweak the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8318762 to be approved

Issues

  • JDK-8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter (Bug - P4)
  • JDK-8318762: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16325/head:pull/16325
$ git checkout pull/16325

Update a local copy of the PR:
$ git checkout pull/16325
$ git pull https://git.openjdk.org/jdk.git pull/16325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16325

View PR using the GUI difftool:
$ git pr show -t 16325

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16325.diff

Webrev

Link to Webrev Comment

@bplb bplb changed the title 8318677: (ch) Add implNote about minBufCap to main variant of Channels.newWriter 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter Oct 23, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay. Given that the spec is extended to allow for the ignore case then I think a CSR will be needed.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter

Reviewed-by: alanb, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • d226014: 8318850: Duplicate code in the LCMSImageLayout
  • c593f8b: 8318091: Remove empty initIDs functions
  • 4f9f195: 8318753: hsdis binutils may place libs in lib64
  • 2915d74: 8318837: javac generates wrong ldc instruction for dynamic constant loads
  • ddd0716: 8317661: [REDO] store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
  • 141dae8: 8318811: Compiler directives parser swallows a character after line comments
  • 667cca9: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"
  • b9dcd4b: 8318964: Fix build failures caused by 8315097
  • d52a995: 8315097: Rename createJavaProcessBuilder
  • 957703b: 8307168: Inconsistent validation and handling of --system flag arguments
  • ... and 70 more: https://git.openjdk.org/jdk/compare/8d9a4b43f4fff30fd217dab2c224e641cb913c18...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2023
@bplb
Copy link
Member Author

bplb commented Oct 24, 2023

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-8318677 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 24, 2023
@bplb bplb requested a review from AlanBateman October 24, 2023 23:22
Comment on lines 536 to 538
* The minimum capacity of the internal byte buffer,
* or {@code -1} if an implementation-dependent
* default capacity is to be used
* default capacity is to be used; may be ignored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding this. The implNote says it is ignored, the annotation on the @param says may.

     *         The minimum capacity of the internal byte buffer,
     *         or {@code -1} if an implementation-dependent default capacity is to be used.
     *         The minimum capacity is ignored.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding this. The implNote says it is ignored, the annotation on the @param says may.

The spec allows the value to be ignored, the JDK implementation ignores the value. So it's spec vs. implementation.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

@bplb
Copy link
Member Author

bplb commented Oct 26, 2023

I think this is okay. Given that the spec is extended to allow for the ignore case then I think a CSR will be needed.

I clarified the verbiage slightly in a48c2ec. The CSR changed identically but was not moved back to draft.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Oct 27, 2023
@bplb
Copy link
Member Author

bplb commented Oct 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

Going to push as commit d3534b0.
Since your change was applied there have been 95 commits pushed to the master branch:

  • 864a876: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
  • a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
  • 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
  • 3934127: 8318709: Improve System.nanoTime performance on Windows
  • 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
  • ... and 85 more: https://git.openjdk.org/jdk/compare/8d9a4b43f4fff30fd217dab2c224e641cb913c18...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2023
@openjdk openjdk bot closed this Oct 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@bplb Pushed as commit d3534b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Channels-newWriter-minBufCap-8318677 branch October 30, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants