Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp #16339

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 24, 2023

Hi all,

please review this trivial change to indentation in g1HeapTransition.cpp.

Test: local compilation.

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16339/head:pull/16339
$ git checkout pull/16339

Update a local copy of the PR:
$ git checkout pull/16339
$ git pull https://git.openjdk.org/jdk.git pull/16339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16339

View PR using the GUI difftool:
$ git pr show -t 16339

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16339.diff

Webrev

Link to Webrev Comment

@tschatzl
Copy link
Contributor Author

/label hotspot-gc

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8318702 8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp Oct 24, 2023
@openjdk openjdk bot added rfr Pull request is ready for review hotspot-gc hotspot-gc-dev@openjdk.org labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@tschatzl
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial!

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318702: G1: Fix nonstandard indentation in g1HeapTransition.cpp

Reviewed-by: iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • e67550c: 8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0
  • 8879c78: 8317689: [JVMCI] include error message when CreateJavaVM in libgraal fails
  • f9795d0: 8318222: RISC-V: C2 CmpU3
  • d1077d6: 8316046: x64 platforms unecessarily save xmm16-31 when UseAVX >= 3
  • 21d8a47: 8318701: Fix copyright year
  • d4b7612: 8318240: [AIX] Cleaners.java test failure
  • bf1a14e: 8316470: Incorrect error location for "invalid permits clause" depending on file order
  • 5224e97: 8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher
  • 9bfa082: 8318646: Integer#parseInt("") throws empty NumberFormatException message
  • 3f446c5: 8318528: Rename TestUnstructuredLocking test
  • ... and 3 more: https://git.openjdk.org/jdk/compare/e6f23a90d4a53339a3c9c2b76fc5d317940e4472...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2023
@tschatzl
Copy link
Contributor Author

Thanks @walulyai

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

Going to push as commit 6f35274.
Since your change was applied there have been 15 commits pushed to the master branch:

  • e272098: 8318160: javac does not reject private method reference with type-variable receiver
  • 54c613a: 8318693: Fix rendering for code blocks nested under list items in building.md
  • e67550c: 8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0
  • 8879c78: 8317689: [JVMCI] include error message when CreateJavaVM in libgraal fails
  • f9795d0: 8318222: RISC-V: C2 CmpU3
  • d1077d6: 8316046: x64 platforms unecessarily save xmm16-31 when UseAVX >= 3
  • 21d8a47: 8318701: Fix copyright year
  • d4b7612: 8318240: [AIX] Cleaners.java test failure
  • bf1a14e: 8316470: Incorrect error location for "invalid permits clause" depending on file order
  • 5224e97: 8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher
  • ... and 5 more: https://git.openjdk.org/jdk/compare/e6f23a90d4a53339a3c9c2b76fc5d317940e4472...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2023
@openjdk openjdk bot closed this Oct 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@tschatzl Pushed as commit 6f35274.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8318702-indentation-g1heaptransition branch November 2, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants