8257788: Class fields could be local in the SunJSSE provider

[XueleiFan]

In the SunJSSE provider implementation, there are a few class fields are not used other than the constructors. Those fields could be removed and replaced with local variables.

Bug: https://bugs.openjdk.java.net/browse/JDK-8257788

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257788: Class fields could be local in the SunJSSE provider

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1634/head:pull/1634
$ git checkout pull/1634

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (95eb0f9)

[haimaychao]

Looks good to me.

[shipilev]

Looks fine to me.

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257788: Class fields could be local in the SunJSSE provider

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 05dac03: 8257803: Add -Xbatch to compiler/blackhole tests
• 29a09c8: 8257668: SA JMap - skip non-java thread stack dump for heap dump
• e590618: 8252505: C1/C2 compiler support for blackholes
• 972bc3b: 8256167: Convert JDK use of Reference::get to Reference::refersTo
• 78be334: 8242332: Add SHA3 support to SunPKCS11 provider
• c4339c3: 8243614: Typo in ReentrantLock's Javadoc
• d3ac1bf: 8198390: Test MultiResolutionDrawImageWithTransformTest.java fails when -esa is passed
• 51d325e: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
• e27ea4d: 8257750: writeBuffer field of java.io.DataOutputStream should be final
• dd0b945: 8257531: Super word not applied to a loop of simple Buffer operations
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/fcc84795f66ce0dee116d5a7f13fe27c5fe4f7d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[XueleiFan]

/integrate

[openjdk]

@XueleiFan Since your change was applied there have been 26 commits pushed to the master branch:

• d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
• 74be819: 8257517: LogCompilation: Add -z to the help messages
• 2c04fc0: 8257037: No javac warning when calling deprecated constructor with diamond
• 46b35ac: 8257798: [PPC64] undefined reference to Klass::vtable_start_offset()
• ecd7e47: 8257793: Shenandoah: SATB barrier should only filter out already strongly marked oops
• e08b9ed: 8257820: Remove gc/ergonomics/TestMinHeapSize.java as it is too brittle
• 637b0c6: 8246778: Compiler implementation for Sealed Classes (Second Preview)
• 09707dd: 8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled
• 04ce8e3: 8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle
• 5a03e47: 8255560: Class::isRecord should check that the current class is final and not abstract
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/fcc84795f66ce0dee116d5a7f13fe27c5fe4f7d1...master

Your commit was automatically rebased without conflicts.

Pushed as commit dcf63f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.