JDK-8257789: Fix incremental build of test-image and bundles

[erikj79]

When building the test-bundle incrementally, it always gets rebuilt. This is caused by the prepare-test-image target in TestImage.gmk, where we create a README file as part of a recipe for a PHONY target. This means that the README is always rebuilt, which in turn triggers downstream rebuilds. This is generally a bad pattern that should be avoided.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257789: Fix incremental build of test-image and bundles

Reviewers

• Tim Bell (@tbell29552 - Reviewer) ⚠️ Review applies to 46aee1a
• Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 46aee1a

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1635/head:pull/1635
$ git checkout pull/1635

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erikj79 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (46aee1a)

[tbell29552]

Looks good.

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257789: Fix incremental build of test-image and bundles

Reviewed-by: tbell, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@erikj79 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8257789-test-image-incr
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[erikj79]

/integrate

[openjdk]

@erikj79 This PR has not yet been marked as ready for integration.

[erikj79]

/integrate

[openjdk]

@erikj79 The command integrate can only be used in open pull requests.