Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests #16350

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Oct 24, 2023

The commit includes changes to unblock parallelism for more hotspot:tier4 tests. in test/hotspot/jtreg/vmTestbase/gc/concurrent tests.

Below are the before and after test run comparisons:

Before:
'linux-x86_64-server-release' 9066.56s user 2289.94s system 880% cpu 21:29.15 total
After:
linux-x86_64-server-release': 3159.71s user 264.93s system 2891% cpu 1:58.45 total


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16350/head:pull/16350
$ git checkout pull/16350

Update a local copy of the PR:
$ git checkout pull/16350
$ git pull https://git.openjdk.org/jdk.git pull/16350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16350

View PR using the GUI difftool:
$ git pr show -t 16350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16350.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@elifaslan1
Copy link
Contributor Author

@lmesnik could you please test this to your system and report the results? TIA

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@elifaslan1 The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 24, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

@shipilev
Copy link
Member

This look good to me. @lmesnik should approve before we integrate.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing is also good.

@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests

Reviewed-by: shade, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 43f31d7: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • cee44a6: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • b026d0b: 8312980: C2: "malformed control flow" created during incremental inlining
  • 3abd772: 8316017: Refactor timeout handler in PassFailJFrame
  • 202c013: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • c587211: 8316003: Update FileChooserSymLinkTest.java to HTML instructions
  • 42b9ac8: 8294156: Allow PassFailJFrame.Builder to create test UI
  • 14090ef: 8294158: HTML formatting for PassFailJFrame instructions
  • d2d1592: 8318713: G1: Use more accurate age in predict_eden_copy_time_ms
  • c3cdfe2: 8318692: Add instructions for creating Ubuntu-based sysroot for cross compilation
  • ... and 7 more: https://git.openjdk.org/jdk/compare/116503754c4c4bdb91685955ef4456bc76f751c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@elifaslan1
Your change (at version 3e536d2) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit 29d462a.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 43f31d7: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • cee44a6: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • b026d0b: 8312980: C2: "malformed control flow" created during incremental inlining
  • 3abd772: 8316017: Refactor timeout handler in PassFailJFrame
  • 202c013: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • c587211: 8316003: Update FileChooserSymLinkTest.java to HTML instructions
  • 42b9ac8: 8294156: Allow PassFailJFrame.Builder to create test UI
  • 14090ef: 8294158: HTML formatting for PassFailJFrame instructions
  • d2d1592: 8318713: G1: Use more accurate age in predict_eden_copy_time_ms
  • c3cdfe2: 8318692: Add instructions for creating Ubuntu-based sysroot for cross compilation
  • ... and 7 more: https://git.openjdk.org/jdk/compare/116503754c4c4bdb91685955ef4456bc76f751c4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@phohensee @elifaslan1 Pushed as commit 29d462a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
4 participants