8318788: java/net/Socks/SocksSocketProxySelectorTest.java fails on machines with no IPv6 link-local addresses

[djelinski]

The test was failing on machines with no link-local addresses configured; JUnit's ParameterizedTest fails if the parameter source returns no parameters, and linkLocalIpv6Literals was used as a parameter source.

I changed the test to non-parameterized; the test now uses the first address from linkLocalIpv6Literals, and is aborted if the method returns no addresses.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318788: java/net/Socks/SocksSocketProxySelectorTest.java fails on machines with no IPv6 link-local addresses (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16356/head:pull/16356
$ git checkout pull/16356

Update a local copy of the PR:
$ git checkout pull/16356
$ git pull https://git.openjdk.org/jdk.git pull/16356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16356

View PR using the GUI difftool:
$ git pr show -t 16356

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16356.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f4061af5)

[jaikiran]

Hello Daniel, the change looks OK to me. Is it intentional that you want to test only one of the IP addresses (if available) from the stream instead of using a loop to test all of them (when available)?

[djelinski]

Hi Jaikiran, thanks for checking! Testing a single address should be sufficient to verify the functionality.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318788: java/net/Socks/SocksSocketProxySelectorTest.java fails on machines with no IPv6 link-local addresses

Reviewed-by: jpai, dfuchs, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 723db2d: 8305321: Remove unused exports in java.desktop
• 811b436: 8318720: G1: Memory leak in G1CodeRootSet after JDK-8315503
• a542f73: 8318843: ProblemList java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp
• d96f38b: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
• 10427c0: 8318613: ChoiceFormat patterns are not well tested
• ca3bdfc: 8318186: ChoiceFormat inconsistency between applyPattern() and setChoices()
• a520887: 8318487: Specification of the ListFormat.equals() method can be improved
• cf4ede0: 8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines
• 9e98ee6: 8318735: RISC-V: Enable related hotspot tests run on riscv
• 29d462a: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
• ... and 11 more: https://git.openjdk.org/jdk/compare/d7205e690fe92464caee9122e11a88b4cc5c2c2d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

LGTM

[MBaesken]

Fixed our issues on AIX that were observed one day ago in the test java/net/Socks/SocksSocketProxySelectorTest.java .

[djelinski]

Thanks for checking!

/integrate

[openjdk]

Going to push as commit 970cd20.
Since your change was applied there have been 22 commits pushed to the master branch:

• 37c40a1: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
• 723db2d: 8305321: Remove unused exports in java.desktop
• 811b436: 8318720: G1: Memory leak in G1CodeRootSet after JDK-8315503
• a542f73: 8318843: ProblemList java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp
• d96f38b: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
• 10427c0: 8318613: ChoiceFormat patterns are not well tested
• ca3bdfc: 8318186: ChoiceFormat inconsistency between applyPattern() and setChoices()
• a520887: 8318487: Specification of the ListFormat.equals() method can be improved
• cf4ede0: 8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines
• 9e98ee6: 8318735: RISC-V: Enable related hotspot tests run on riscv
• ... and 12 more: https://git.openjdk.org/jdk/compare/d7205e690fe92464caee9122e11a88b4cc5c2c2d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 970cd20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.