Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318805: RISC-V: Wrong comments instructions cost in riscv.ad #16357

Closed
wants to merge 1 commit into from

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Oct 25, 2023

Hi,
Can you review this minor change in the comments of riscv.ad for the instruction cost?
Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318805: RISC-V: Wrong comments instructions cost in riscv.ad (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16357/head:pull/16357
$ git checkout pull/16357

Update a local copy of the PR:
$ git checkout pull/16357
$ git pull https://git.openjdk.org/jdk.git pull/16357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16357

View PR using the GUI difftool:
$ git pr show -t 16357

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16357.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2023

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 25, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.
BTW: Seems that JBS title could be improved, maybe something more specific like: "RISC-V: Wrong comments for integer division instruction costs in riscv.ad"

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318805: RISC-V: Wrong comments instructions cost in riscv.ad

Reviewed-by: luhenry, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 723db2d: 8305321: Remove unused exports in java.desktop
  • 811b436: 8318720: G1: Memory leak in G1CodeRootSet after JDK-8315503
  • a542f73: 8318843: ProblemList java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp
  • d96f38b: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 10427c0: 8318613: ChoiceFormat patterns are not well tested
  • ca3bdfc: 8318186: ChoiceFormat inconsistency between applyPattern() and setChoices()
  • a520887: 8318487: Specification of the ListFormat.equals() method can be improved
  • cf4ede0: 8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines
  • 9e98ee6: 8318735: RISC-V: Enable related hotspot tests run on riscv
  • 29d462a: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • ... and 27 more: https://git.openjdk.org/jdk/compare/bf1a14e3672b7d92b10d16210faf4fd99a860731...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2023
@Hamlin-Li
Copy link
Author

/integrate
Thanks @luhenry @RealFYang for your reviewing.

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

Going to push as commit 3cea892.
Since your change was applied there have been 40 commits pushed to the master branch:

  • bc1ba24: 8316437: JFR: assert(!tl->has_java_buffer()) failed: invariant
  • 970cd20: 8318788: java/net/Socks/SocksSocketProxySelectorTest.java fails on machines with no IPv6 link-local addresses
  • 37c40a1: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 723db2d: 8305321: Remove unused exports in java.desktop
  • 811b436: 8318720: G1: Memory leak in G1CodeRootSet after JDK-8315503
  • a542f73: 8318843: ProblemList java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp
  • d96f38b: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 10427c0: 8318613: ChoiceFormat patterns are not well tested
  • ca3bdfc: 8318186: ChoiceFormat inconsistency between applyPattern() and setChoices()
  • a520887: 8318487: Specification of the ListFormat.equals() method can be improved
  • ... and 30 more: https://git.openjdk.org/jdk/compare/bf1a14e3672b7d92b10d16210faf4fd99a860731...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2023
@openjdk openjdk bot closed this Oct 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@Hamlin-Li Pushed as commit 3cea892.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the minor-comment-fix branch February 27, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants