8257845: Integrate JEP 390

[dansmithcode]

Integration of JEP 390.

Development has been broken into 5 tasks, each with its own JBS issue:

• JDK-8252180: Deprecate wrapper class constructors for removal (rriggs)
• JDK-8254047: Revise "value-based class" & apply to wrappers (dlsmith)
• JDK-8252181:Define & apply annotation jdk.internal.ValueBased (rriggs)
• JDK-8252183: Add 'lint' warning for @valuebased classes (sadayapalam)
• JDK-8257027: Diagnose synchronization on @valuebased classes (lfoltan)

All changes have been previously reviewed and integrated into the jep390 branch of the valhalla repository. See the subtasks of the 5 JBS issues for these changes, including discussion and links to reviews. (Reviewers: mchung, dlsmith, jlaskey, rriggs, lfoltan, fparain, hseigel.)

CSRs have also been completed or are nearly complete:

• JDK-8254324 for wrapper class constructor deprecation
• JDK-8254944 for revisions to "value-based class"
• JDK-8256023 for new javac lint warnings

Here's an overview of the files changed:

• src/hotspot: implementing diagnostics when monitorenter is applied to an instance of a class tagged with jdk.internal.ValueBased. This enhances previous work that produced such diagnostics for the primitive wrapper classes.

• src/java.base/share/classes/java/lang: deprecating for removal the wrapper class constructors; revising the definition of "value-based class" in ValueBased.html and the description used by linking classes; applying "value-based class" to the primitive wrapper classes; marking value-based classes with @jdk.internal.ValueBased.

• src/java.base/share/classes/java/lang/constant: no longer designating these classes as "value-based", since they rely heavily on field inheritance.

• src/java.base/share/classes/java/time: revising the description used to link to ValueBased.html; marking value-based classes with @jdk.internal.ValueBased.

• src/java.base/share/classes/java/util: revising the description used to link to ValueBased.html; marking value-based classes with @jdk.internal.ValueBased.

• src/java.base/share/classes/jdk/internal: define the @jdk.internal.ValueBased annotation.

• src/java.management.rmi: removing uses of wrapper class constructors.

• src/java.xml: removing uses of wrapper class constructors.

• src/jdk.compiler: implementing the synchronization lint category, which reports attempts to synchronize on classes and interfaces annotated with @jdk.internal.ValueBased.

• src/jdk.incubator.foreign: revising the description used to link to ValueBased.html. (Applying @jdk.internal.ValueBased would require a special module export, which was not deemed necessary for an incubating API.)

• src/jdk.internal.vm.compiler: suppressing javac deprecation and synchronization warnings in tests

• src/jdk.jfr: supplementary changes for HotSpot diagnostics

• test: testing new javac and HotSpot behavior; removing usages of deprecated wrapper class constructors from tests, or suppressing deprecation warnings; revising the description used to link to ValueBased.html.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8257845: Integrate JEP 390
• JDK-8254047: [JEP 390] Revise "value-based class" & apply to wrappers
• JDK-8252181: [JEP 390] Define & apply annotation jdk.internal.ValueBased
• JDK-8252183: [JEP 390] Add 'lint' warning for @valuebased classes
• JDK-8257027: [JEP 390] Diagnose synchronization on @valuebased classes
• JDK-8252180: [JEP 390] Deprecate wrapper class constructors for removal

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Harold Seigel (@hseigel - Reviewer)
• Mandy Chung (@mlchung - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Contributors

• Roger Riggs <rriggs@openjdk.org>
• Srikanth Adayapalam <sadayapalam@openjdk.org>
• Lois Foltan <lfoltan@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1636/head:pull/1636
$ git checkout pull/1636

[bridgekeeper]

👋 Welcome back dlsmith! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dansmithcode The following labels will be automatically applied to this pull request:

• build
• compiler
• core-libs
• hotspot
• i18n
• javadoc
• jmx
• kulla
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7c5e5bf)

[dansmithcode]

/help

[openjdk]

@dansmithcode Available commands:

• cc - add or remove an additional classification label
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• label - add or remove an additional classification label
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests

[dansmithcode]

/issue 8254047

[openjdk]

@dansmithcode
Adding additional issue to issue list: 8254047: [JEP 390] Revise "value-based class" & apply to wrappers.

[dansmithcode]

/issue 8252181

[dansmithcode]

/label remove javadoc

[dansmithcode]

/label remove javadoc

[openjdk]

@dansmithcode
The i18n label was successfully removed.

[dansmithcode]

/label remove kulla

[openjdk]

@dansmithcode
The javadoc label was successfully removed.

[openjdk]

@dansmithcode The javadoc label was not set.

[openjdk]

@dansmithcode
The kulla label was successfully removed.

[dansmithcode]

/label remove serviceability

[openjdk]

@dansmithcode
The serviceability label was successfully removed.

[dansmithcode]

/label remove jmx

[openjdk]

@dansmithcode
The jmx label was successfully removed.

[dansmithcode]

/label remove build

[openjdk]

@dansmithcode
The build label was successfully removed.

[dansmithcode]

/issue 8252180

[openjdk]

@dansmithcode
Adding additional issue to issue list: 8252180: [JEP 390] Deprecate wrapper class constructors for removal.

[mlchung]

core-libs and hotspot change look okay.

[dansmithcode]

/integrate

[openjdk]

@dansmithcode Since your change was applied there have been 114 commits pushed to the master branch:

• ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
• c47ab5f: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event
• 291ba97: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")
• f48d5d1: 8257789: Fix incremental build of test-image and bundles
• 1a9ed92: 8200102: NativeLibraryTest.java fails intermittently, unloaded count is not same as expected
• 264feb3: 8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments
• 044616b: 8252049: Native memory leak in ciMethodData ctor
• fab6158: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException
• 936a7ac: 8252797: Non-PCH build fails on Ubuntu 16.4 when building with gtests
• d0c5265: 8256149: Weird AST structure for incomplete member select
• ... and 104 more: https://git.openjdk.java.net/jdk/compare/93b6ab56ae1499616d38c0b62f4256f1d7c17ce5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 48d8650.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.