-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318834: s390x: Debug builds are missing debug helpers #16365
Conversation
👋 Welcome back aph! A progress list of the required criteria for merging this PR into |
@theRealAph The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment in the block says:
# do this on s390x also for libjvm (where serviceability agent is not supported)
...which I read as "if we enable this, SA would break". Does serviceability/sa
pass in both release and fastdebug with this change?
The block in question also works when link-time gc is enabled, which is only so on s390x by default: jdk/make/autoconf/jdk-options.m4 Lines 105 to 110 in d96f38b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (and seems helpful).
Those link-time options had been introduced many years ago in an effort to trim binary sizes. The serviceability agent was never ported to s390x.
@theRealAph This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
It does, but without functions-as-sections link-time GC has no effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, so this is a fix that is S390X specific. I missed that, I thought we were talking about generic debug builds. Okay then!
I read it as meaning "we don't enable the helpers, because without serviceability agent there's no point in having them. Which is very far from the truth. As you might expect, SA tests don't run on s390:
I don't think they're specificially excluded on s390. |
/integrate |
Going to push as commit e1a458e.
Your commit was automatically rebased without conflicts. |
@theRealAph Pushed as commit e1a458e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
On s390x only, HotSpot is built by GCC with -ffunction-sections.
This means that debug helpers such as ps() and pfl() are not available. These helpers are extremely useful in debugging, so it makes no sense to omit them from debug builds.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16365/head:pull/16365
$ git checkout pull/16365
Update a local copy of the PR:
$ git checkout pull/16365
$ git pull https://git.openjdk.org/jdk.git pull/16365/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16365
View PR using the GUI difftool:
$ git pr show -t 16365
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16365.diff
Webrev
Link to Webrev Comment