-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8318957: enhance agentlib:jdwp help output by info about allow option #16393
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
Webrevs
|
"allow=<IP|IP-list> If server=y, allows connections only from the IP addresses/subnets specified.\n" | ||
" * (allows connection from any address)\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering if we should also mention to use "+" to separate addresses in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can add this, I posted another commit adding some information.
Hi Chris, are you fine with the latest version ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for taking care of this.
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Hi Chris, thanks for the review ! /integrate |
Going to push as commit 53bb7cd.
Your commit was automatically rebased without conflicts. |
The allow option of agentlib:jdwp has been introduced a long time ago (see JDK-8061228) and is documented here :
https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options
However it is still missing in the agentlib:jdwp help output and should be added there too.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16393/head:pull/16393
$ git checkout pull/16393
Update a local copy of the PR:
$ git checkout pull/16393
$ git pull https://git.openjdk.org/jdk.git pull/16393/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16393
View PR using the GUI difftool:
$ git pr show -t 16393
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16393.diff
Webrev
Link to Webrev Comment