JDK-8318961: increase javacserver connection timeout values and max retry attempts

[MBaesken]

Increase javacserver connection timeout values and max retry attempts for better make stability on some slower machines.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318961: increase javacserver connection timeout values and max retry attempts (Enhancement - P4)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer) ⚠️ Review applies to 314ddfbb
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16397/head:pull/16397
$ git checkout pull/16397

Update a local copy of the PR:
$ git checkout pull/16397
$ git pull https://git.openjdk.org/jdk.git pull/16397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16397

View PR using the GUI difftool:
$ git pr show -t 16397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16397.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following labels will be automatically applied to this pull request:

• build
• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a165403f)
• 00: Full (314ddfbb)

[RealCLanger]

Looks good to me, these changes seem to have improved nightbuilds at SAP. But somebody from build group should take a look, of course.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318961: increase javacserver connection timeout values and max retry attempts

Reviewed-by: clanger, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
• 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
• c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
• 3934127: 8318709: Improve System.nanoTime performance on Windows
• 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
• 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
• 988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
• ce0ca47: 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode
• db34025: 8318827: RISC-V: Improve readability of fclass result testing
• 1ec0d02: 8318225: RISC-V: C2 UModI
• ... and 7 more: https://git.openjdk.org/jdk/compare/667cca9d7aef1ff4abe630cefaac34c0b1646925...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

Not sure increasing the wait time is a good idea. If I'm reading this right, that means 8 seconds between each attempt if they are timing out. Will your problem still be alleviated if we keep the wait time at 2000?

[MBaesken]

I adjusted the WAIT_BETWEEN_CONNECT_ATTEMPTS; Let's how this works.

[MBaesken]

Hi Christoph and Erik, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit b9983c7.
Since your change was applied there have been 18 commits pushed to the master branch:

• a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
• 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
• c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
• 3934127: 8318709: Improve System.nanoTime performance on Windows
• 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
• 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
• 988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
• ce0ca47: 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode
• db34025: 8318827: RISC-V: Improve readability of fclass result testing
• ... and 8 more: https://git.openjdk.org/jdk/compare/667cca9d7aef1ff4abe630cefaac34c0b1646925...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit b9983c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.