Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250668 : Clean up method_oop names in adlc #164

Closed
wants to merge 1 commit into from
Closed

8250668 : Clean up method_oop names in adlc #164

wants to merge 1 commit into from

Conversation

@JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Sep 15, 2020

Relates to: https://bugs.openjdk.java.net/browse/JDK-8250668
Tested on: x86_64 {windows, linux, os x} x {jdk-tier1-part1..3, hotspot-tier1-gc}
Follow up from this thread: https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039846.html

Rename occurrences of 'method_oop' under src/ to just `method'.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/164/head:pull/164
$ git checkout pull/164

@JohnTortugo
Copy link
Contributor Author

@JohnTortugo JohnTortugo commented Sep 15, 2020

/covered

Loading

@bridgekeeper bridgekeeper bot added the oca label Sep 15, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

Hi @JohnTortugo, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user JohnTortugo" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@JohnTortugo The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@openjdk openjdk bot added the hotspot label Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

Loading

Copy link
Contributor

@coleenp coleenp left a comment

Looks good! You found a couple that I missed as well. Thank you!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@JohnTortugo This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8250668: Clean up method_oop names in adlc

Reviewed-by: coleenp, adityam, thartmann
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 17 commits pushed to the master branch:

  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/ac9d1b08ee4a9f54cd75a4115adffcc4c0fb105d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 57f92d23b1049e7bfc1d54567757713ca1dd0f3c.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 15, 2020
@JohnTortugo
Copy link
Contributor Author

@JohnTortugo JohnTortugo commented Sep 16, 2020

/integrate

Loading

@JohnTortugo
Copy link
Contributor Author

@JohnTortugo JohnTortugo commented Sep 16, 2020

@coleenp - Can you please merge this PR?

Loading

@openjdk openjdk bot added the sponsor label Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@JohnTortugo
Your change (at version 722a3a6) is now ready to be sponsored by a Committer.

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

Loading

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 16, 2020

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@TobiHartmann @JohnTortugo Since your change was applied there have been 17 commits pushed to the master branch:

  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/ac9d1b08ee4a9f54cd75a4115adffcc4c0fb105d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2caa20a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants