Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257517: LogCompilation: Add -z to the help messages #1640

Closed
wants to merge 1 commit into from

Conversation

ericcaspole
Copy link

@ericcaspole ericcaspole commented Dec 5, 2020

I forgot to add a help message with JDK-8255965.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257517: LogCompilation: Add -z to the help messages

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1640/head:pull/1640
$ git checkout pull/1640

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 5, 2020

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 5, 2020

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Dec 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 5, 2020

Webrevs

cl4es
cl4es approved these changes Dec 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 5, 2020

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257517: LogCompilation: Add -z to the help messages

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 5, 2020
@ericcaspole
Copy link
Author

@ericcaspole ericcaspole commented Dec 7, 2020

/integrate

@openjdk openjdk bot closed this Dec 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@ericcaspole Since your change was applied there have been 18 commits pushed to the master branch:

  • 2c04fc0: 8257037: No javac warning when calling deprecated constructor with diamond
  • 46b35ac: 8257798: [PPC64] undefined reference to Klass::vtable_start_offset()
  • ecd7e47: 8257793: Shenandoah: SATB barrier should only filter out already strongly marked oops
  • e08b9ed: 8257820: Remove gc/ergonomics/TestMinHeapSize.java as it is too brittle
  • 637b0c6: 8246778: Compiler implementation for Sealed Classes (Second Preview)
  • 09707dd: 8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled
  • 04ce8e3: 8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle
  • 5a03e47: 8255560: Class::isRecord should check that the current class is final and not abstract
  • 8e8e584: 8257588: Make os::_page_sizes a bitmask
  • 566d77a: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/c4339c3064190bd10fdba64f85a501a2f3d52685...master

Your commit was automatically rebased without conflicts.

Pushed as commit 74be819.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ericcaspole ericcaspole deleted the JDK-8257517 branch Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
2 participants