Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257718: LogCompilation: late_inline doesnt work right for JDK 8 logs #1641

Closed
wants to merge 1 commit into from

Conversation

@ericcaspole
Copy link

@ericcaspole ericcaspole commented Dec 5, 2020

As I mentioned in the JBS, this change handles the case where late_inline does not contain inline_id.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257718: LogCompilation: late_inline doesnt work right for JDK 8 logs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1641/head:pull/1641
$ git checkout pull/1641

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 5, 2020

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 5, 2020

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 5, 2020

Webrevs

cl4es
cl4es approved these changes Dec 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 5, 2020

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257718: LogCompilation: late_inline doesnt work right for JDK 8 logs

Reviewed-by: redestad, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • a5297bd: 8254939: macOS: unused function 'replicate4_imm'
  • 36c0600: 8257805: Add compiler/blackhole tests to tier1
  • 395b6bd: 8257817: Shenandoah: Don't race with conc-weak-in-progress flag in weak-LRB
  • a265c20: 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource
  • e3793e5: 8257514: Fix the issues in jdk.jpackage identified by SpotBugs
  • bbc44f5: 8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments
  • b4b9828: 8254784: javac should reject records with @SafeVarargs applied to varargs record component
  • dcf63f8: 8257788: Class fields could be local in the SunJSSE provider
  • d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • 74be819: 8257517: LogCompilation: Add -z to the help messages
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/c4339c3064190bd10fdba64f85a501a2f3d52685...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 5, 2020
@ericcaspole
Copy link
Author

@ericcaspole ericcaspole commented Dec 7, 2020

/integrate

@openjdk openjdk bot closed this Dec 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@ericcaspole Since your change was applied there have been 29 commits pushed to the master branch:

  • 6937d9f: 8257799: Update JLS cross-references in java.compiler
  • a5297bd: 8254939: macOS: unused function 'replicate4_imm'
  • 36c0600: 8257805: Add compiler/blackhole tests to tier1
  • 395b6bd: 8257817: Shenandoah: Don't race with conc-weak-in-progress flag in weak-LRB
  • a265c20: 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource
  • e3793e5: 8257514: Fix the issues in jdk.jpackage identified by SpotBugs
  • bbc44f5: 8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments
  • b4b9828: 8254784: javac should reject records with @SafeVarargs applied to varargs record component
  • dcf63f8: 8257788: Class fields could be local in the SunJSSE provider
  • d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/c4339c3064190bd10fdba64f85a501a2f3d52685...master

Your commit was automatically rebased without conflicts.

Pushed as commit f92745d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ericcaspole ericcaspole deleted the JDK-8257718 branch Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants