Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode #16410

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 29, 2023

A trivial fix to ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
on linux-aarch64 in Xcomp mode.

The test is already ProblemListed in -Xcomp mode for linux-x64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16410/head:pull/16410
$ git checkout pull/16410

Update a local copy of the PR:
$ git checkout pull/16410
$ git pull https://git.openjdk.org/jdk.git pull/16410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16410

View PR using the GUI difftool:
$ git pr show -t 16410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16410.diff

…BaseTest.java on linux-aarch64 in Xcomp mode
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability
/label add hotspot-compiler

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review October 29, 2023 14:12
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/integrate auto

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Oct 29, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 29, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 29, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@jaikiran
Copy link
Member

I don't have prior knowledge of this test, but this a trivial problem listing PR and the proposed change looks good to me.

@openjdk openjdk bot added the auto label Oct 29, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2023

Going to push as commit ce0ca47.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2023
@openjdk openjdk bot closed this Oct 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@openjdk[bot] Pushed as commit ce0ca47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Oct 29, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8319067 branch October 29, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants