Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319106: Remove unimplemented TaskTerminator::do_delay_step #16415

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 30, 2023

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319106: Remove unimplemented TaskTerminator::do_delay_step (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16415/head:pull/16415
$ git checkout pull/16415

Update a local copy of the PR:
$ git checkout pull/16415
$ git pull https://git.openjdk.org/jdk.git pull/16415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16415

View PR using the GUI difftool:
$ git pr show -t 16415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16415.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8319106 8319106: Remove unimplemented TaskTerminator::do_delay_step Oct 30, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 30, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319106: Remove unimplemented TaskTerminator::do_delay_step

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • d3534b0: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter
  • 864a876: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
  • a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
  • 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2023

Going to push as commit 5411ad2.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 75ce02f: 8318951: Additional negative value check in JPEG decoding
  • 328b381: 8009550: PlatformPCSC should load versioned so
  • d051f22: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  • 1ca2cfa: 8310933: Copying from runtime image to application image should not follow symlinks
  • d3534b0: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter
  • 864a876: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
  • a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
  • ... and 2 more: https://git.openjdk.org/jdk/compare/3934127b087ade1c1286008df3497ca6d84778a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2023
@openjdk openjdk bot closed this Oct 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

@albertnetymk Pushed as commit 5411ad2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch October 31, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants