JDK-8318467 : [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads

[viktorklang-ora]

Discussed with @DougLea and adjusting the queue capacity to at least the number of participating threads seems like the most sensible fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16419/head:pull/16419
$ git checkout pull/16419

Update a local copy of the PR:
$ git checkout pull/16419
$ git pull https://git.openjdk.org/jdk.git pull/16419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16419

View PR using the GUI difftool:
$ git pr show -t 16419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16419.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f7a12af9)
• 00: Full (f4afe57e)

[DougLea]

Thanks for figuring out where to make the adjustment! Looks good.

[viktorklang-ora]

@DougLea Yeah it took some digging to find the right approach 👍

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2279 new commits pushed to the master branch:

• d3c3f0e: 8317951: Refactor loading of zip library to help resolve JDK-8315220
• 576c9bc: 8318492: Http2ClientImpl should attempt to close and remove connection in stop()
• 5411ad2: 8319106: Remove unimplemented TaskTerminator::do_delay_step
• 75ce02f: 8318951: Additional negative value check in JPEG decoding
• 328b381: 8009550: PlatformPCSC should load versioned so
• d051f22: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
• 1ca2cfa: 8310933: Copying from runtime image to application image should not follow symlinks
• d3534b0: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter
• 864a876: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
• 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
• ... and 2269 more: https://git.openjdk.org/jdk/compare/e2b1013f11fc605501c3bf77976facb9b870d28e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[viktorklang-ora]

/integrate

[openjdk]

@viktorklang-ora
Your change (at version f7a12af) is now ready to be sponsored by a Committer.

[AlanBateman]

/sponsor

[openjdk]

Going to push as commit e05cafd.
Since your change was applied there have been 2279 commits pushed to the master branch:

• d3c3f0e: 8317951: Refactor loading of zip library to help resolve JDK-8315220
• 576c9bc: 8318492: Http2ClientImpl should attempt to close and remove connection in stop()
• 5411ad2: 8319106: Remove unimplemented TaskTerminator::do_delay_step
• 75ce02f: 8318951: Additional negative value check in JPEG decoding
• 328b381: 8009550: PlatformPCSC should load versioned so
• d051f22: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
• 1ca2cfa: 8310933: Copying from runtime image to application image should not follow symlinks
• d3534b0: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter
• 864a876: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
• 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
• ... and 2269 more: https://git.openjdk.org/jdk/compare/e2b1013f11fc605501c3bf77976facb9b870d28e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman @viktorklang-ora Pushed as commit e05cafd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.