Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257799: Update JLS cross-references in java.compiler #1642

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 5, 2020

A few of the @jls tags in the java.compiler module don't make the corresponding JLS section anymore; the null literal section and constant expression sections were renumbered.

This change makes corrects the mismatches.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257799: Update JLS cross-references in java.compiler

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1642/head:pull/1642
$ git checkout pull/1642

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2020

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8257799 8257799: Update JLS cross-references in java.compiler Dec 5, 2020
@openjdk openjdk bot added the rfr label Dec 5, 2020
@openjdk
Copy link

openjdk bot commented Dec 5, 2020

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Dec 5, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2020

Webrevs

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Approved.

It would also be reasonable to semi-automate checking whether this sort of edit is necessary as a formal jtreg test, perhaps using a static checked-in copy of the JLS and JVMS index, which is maybe updated near the end of each release. If you think that is worth pursuing, maybe you could file an issue in JBS.

@openjdk
Copy link

openjdk bot commented Dec 7, 2020

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257799: Update JLS cross-references in java.compiler

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • a5297bd: 8254939: macOS: unused function 'replicate4_imm'
  • 36c0600: 8257805: Add compiler/blackhole tests to tier1
  • 395b6bd: 8257817: Shenandoah: Don't race with conc-weak-in-progress flag in weak-LRB
  • a265c20: 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource
  • e3793e5: 8257514: Fix the issues in jdk.jpackage identified by SpotBugs
  • bbc44f5: 8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments
  • b4b9828: 8254784: javac should reject records with @SafeVarargs applied to varargs record component
  • dcf63f8: 8257788: Class fields could be local in the SunJSSE provider
  • d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • 74be819: 8257517: LogCompilation: Add -z to the help messages
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/d3ac1bf16c2e6ffc1f5b1759631750cb7eac2e17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 7, 2020
@jddarcy
Copy link
Member Author

jddarcy commented Dec 7, 2020

/integrate

@openjdk openjdk bot closed this Dec 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2020
@openjdk
Copy link

openjdk bot commented Dec 7, 2020

@jddarcy Since your change was applied there have been 29 commits pushed to the master branch:

  • a5297bd: 8254939: macOS: unused function 'replicate4_imm'
  • 36c0600: 8257805: Add compiler/blackhole tests to tier1
  • 395b6bd: 8257817: Shenandoah: Don't race with conc-weak-in-progress flag in weak-LRB
  • a265c20: 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource
  • e3793e5: 8257514: Fix the issues in jdk.jpackage identified by SpotBugs
  • bbc44f5: 8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments
  • b4b9828: 8254784: javac should reject records with @SafeVarargs applied to varargs record component
  • dcf63f8: 8257788: Class fields could be local in the SunJSSE provider
  • d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • 74be819: 8257517: LogCompilation: Add -z to the help messages
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/d3ac1bf16c2e6ffc1f5b1759631750cb7eac2e17...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6937d9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Dec 7, 2020

Mailing list message from Joe Darcy on compiler-dev:

On 12/7/2020 11:28 AM, Jonathan Gibbons wrote:

On Sat, 5 Dec 2020 21:37:34 GMT, Joe Darcy <darcy at openjdk.org> wrote:

A few of the @jls tags in the java.compiler module don't make the corresponding JLS section anymore; the null literal section and constant expression sections were renumbered.

This change makes corrects the mismatches.
Approved.

It would also be reasonable to semi-automate checking whether this sort of edit is necessary as a formal jtreg test, perhaps using a static checked-in copy of the JLS and JVMS index, which is maybe updated near the end of each release. If you think that is worth pursuing, maybe you could file an issue in JBS.

Filed JDK-8257854: Add testing for stale @jls and @JVMS tags.

Thanks,

-Joe

@jddarcy jddarcy deleted the JDK-8257799 branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
2 participants