-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318962: Update ProcessTools javadoc with suggestions in 8315097 #16430
Conversation
👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into |
Webrevs
|
* Executes a test jvm process, waits for it to finish and returns | ||
* the process output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping the support test.vm.opts and test.java.opts deserves to be explicitly documented.
Can you confirm that all existing uses no longer need the test options and have already been remediated in 8315097.
Sorry Roger, I went a bit funny in the head... I updated the documentation to correctly state that the propagating API is used. |
WRT the bug title and PR title... The leading "Javadoc:" implies a change to the javadoc tool. Perhaps
|
@lkorinth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 7e4cb2f.
Your commit was automatically rebased without conflicts. |
Updates to javadoc after improvement ideas in the review of 8315097. I have also removed the incomplete invocation command line. I also removed incomplete information in
executeTestJvm
and added a link tocreateLimitedTestJavaProcessBuilder
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16430/head:pull/16430
$ git checkout pull/16430
Update a local copy of the PR:
$ git checkout pull/16430
$ git pull https://git.openjdk.org/jdk.git pull/16430/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16430
View PR using the GUI difftool:
$ git pr show -t 16430
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16430.diff
Webrev
Link to Webrev Comment