Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318962: Update ProcessTools javadoc with suggestions in 8315097 #16430

Closed
wants to merge 2 commits into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Oct 31, 2023

Updates to javadoc after improvement ideas in the review of 8315097. I have also removed the incomplete invocation command line. I also removed incomplete information in executeTestJvm and added a link to createLimitedTestJavaProcessBuilder


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318962: Update ProcessTools javadoc with suggestions in 8315097 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16430/head:pull/16430
$ git checkout pull/16430

Update a local copy of the PR:
$ git checkout pull/16430
$ git pull https://git.openjdk.org/jdk.git pull/16430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16430

View PR using the GUI difftool:
$ git pr show -t 16430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16430.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

@lkorinth The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 31, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2023

Webrevs

Comment on lines +611 to +612
* Executes a test jvm process, waits for it to finish and returns
* the process output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the support test.vm.opts and test.java.opts deserves to be explicitly documented.

Can you confirm that all existing uses no longer need the test options and have already been remediated in 8315097.

@lkorinth
Copy link
Contributor Author

Sorry Roger, I went a bit funny in the head...

I updated the documentation to correctly state that the propagating API is used.

@RogerRiggs
Copy link
Contributor

WRT the bug title and PR title...

The leading "Javadoc:" implies a change to the javadoc tool. Perhaps

Update ProcessTools javadoc with suggestions in 8315097

@lkorinth lkorinth changed the title 8318962: Javadoc: Update ProcessTools after suggestions in 8315097 8318962: Update ProcessTools javadoc with suggestions in 8315097 Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318962: Update ProcessTools javadoc with suggestions in 8315097

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • ab19348: 8318647: Serial: Refactor BlockOffsetTable
  • b4f5379: 8304939: os::win32::exit_process_or_thread should be marked noreturn
  • 0461d9a: 8318016: Per-compilation memory ceiling
  • 2a76ad9: 8318683: compiler/c2/irTests/TestPhiDuplicatedConversion.java "Failed IR Rules (2) of Methods (2)"
  • b3fec6b: 8306980: Generated docs should contain correct Legal Documents
  • 1139482: 8316132: CDSProtectionDomain::get_shared_protection_domain should check for exception
  • 2182c93: 8313643: Update HarfBuzz to 8.2.2
  • 613a3cc: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • 613d32c: 8169475: WheelModifier.java fails by timeout
  • f1e8787: 8317609: Classfile API fails to verify /jdk.jcmd/sun/tools/jstat/Alignment.class
  • ... and 32 more: https://git.openjdk.org/jdk/compare/d2260146c9930002e430a874f2585d699dedc155...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2023
@lkorinth
Copy link
Contributor Author

lkorinth commented Nov 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit 7e4cb2f.
Since your change was applied there have been 142 commits pushed to the master branch:

  • 0b58bde: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • b0fc808: 8319725: G1: Subtracting virtual time from wall time after JDK-8319204
  • a26f7c0: 6928542: Chinese characters in RTF are not decoded
  • 4e8c036: 8319665: [macOS] Obsolete imports of <Carbon/Carbon.h> in java.desktop
  • f4ab952: 8319253: [BACKOUT] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
  • c137b17: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support
  • fa331d7: 8319184: RISC-V: improve MD5 intrinsic
  • 4c0f6c6: 8311961: Update Manual Test Groups for ATR JDK22
  • a6785e4: 8318915: Enhance checks in BigDecimal.toPlainString()
  • 7d25f1c: 8319423: Improve Year.isLeap by checking divisibility by 16
  • ... and 132 more: https://git.openjdk.org/jdk/compare/d2260146c9930002e430a874f2585d699dedc155...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@lkorinth Pushed as commit 7e4cb2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants