8319165: hsdis binutils: warns on empty string as option string

[robehn]

Hi, please consider.

insn_options[0] is set to empty string if there is no options (NULL or empty strings).
Checking it for empty string should cover both cases, caller option is NULL or caller option is empty string.

Tested hsdis no longer gives me the warning.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319165: hsdis binutils: warns on empty string as option string (Bug - P5)

Reviewers

• Hamlin Li (@Hamlin-Li - Reviewer) ⚠️ Review applies to 94ccd7f9
• Jesper Wilhelmsson (@JesperIRL - Reviewer) ⚠️ Review applies to 94ccd7f9
• Andrew Haley (@theRealAph - Reviewer) ⚠️ Review applies to 94ccd7f9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16433/head:pull/16433
$ git checkout pull/16433

Update a local copy of the PR:
$ git checkout pull/16433
$ git pull https://git.openjdk.org/jdk.git pull/16433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16433

View PR using the GUI difftool:
$ git pr show -t 16433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16433.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn The following labels will be automatically applied to this pull request:

• build
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (150c42a2)
• 01: Full - Incremental (94ccd7f9)
• 00: Full (58eb19b1)

[Hamlin-Li]

LGTM, Thanks.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319165: hsdis binutils: warns on empty string as option string

Reviewed-by: mli, jwilhelm, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• 792d829: 8319205: Parallel: Reenable work stealing after JDK-8310031
• 23a96bf: 8318894: G1: Use uint for age in G1SurvRateGroup
• 64f8253: 8317332: Prepare security for permissive-
• 53bb7cd: 8318957: enhance agentlib:jdwp help output by info about allow option
• d6ce62e: 8306561: Possible out of bounds access in print_pointer_information
• 7f31a05: 8319203: Parallel: Rename addr_is_marked_imprecise
• 4a85f6a: 8317132: Prepare HotSpot for permissive-
• 5207443: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false"
• ee57e73: 8317612: ChoiceFormat and MessageFormat constructors call non-final public method
• f262f06: 8319211: Regression in LoopOverNonConstantFP
• ... and 34 more: https://git.openjdk.org/jdk/compare/4679e9aa00c098cff715fb4deeb4d736e1063571...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JesperIRL]

👍🏼

[robehn]

Thanks !

[robehn]

/integrate

[openjdk]

Going to push as commit c146685.
Since your change was applied there have been 71 commits pushed to the master branch:

• 01c0d5d: 8319412: RISC-V: Simple fix of indent in c2_MacroAssembler_riscv.hpp
• df599db: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic
• c099cf5: 8318422: Allow poller threads be virtual threads
• 29cf2c4: 8319053: Segment dump files remain after parallel heap dump on Windows
• ea6a88a: 8318466: Improve spec of NumberFormat's methods with unsupported operations
• de6667c: 8225377: type annotations are not visible to javac plugins across compilation boundaries
• 008ca2a: 8317620: Build JDK tools with ModuleMainClass attribute
• 1a21c1a: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
• 81db172: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return
• be01caf: 8319323: FFM: Harmonize the @throws tags in the javadocs
• ... and 61 more: https://git.openjdk.org/jdk/compare/4679e9aa00c098cff715fb4deeb4d736e1063571...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit c146685.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.