8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305 #1644
@jnimeh This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 89 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the
BTW stupid - somewhat related - question, why does the nonce to be parsed out of a DER blob, shouldn?t there be an getter on the Parameter Spec object? Many protocols would need the raw array, is there a matching spec - or should we add one?
On Mon, 7 Dec 2020 19:53:27 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
Unintuitive is a charitable way to put it. After doFinal the Cipher technically isn't in an uninitialized state per the spec, it's supposed to be in the state it would be immediately following init(). So the wrong behavior would happen in this use case. Will fix.
Hi Bernd, it's not a stupid question at all.? I think what you might be
But both getParameters() and getIV() were doing the wrong thing
On 12/7/2020 5:19 PM, Bernd Eckenfels wrote:
Oh, one other thing in case you weren't talking about this in the
On 12/7/2020 5:39 PM, Jamil Nimeh wrote:
-------------- next part --------------
@jnimeh Since your change was applied there have been 89 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 500ab45.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.