8319174: Enhance robustness of some j.m.BigInteger constructors

[rgiulietti]

Enhance java.math.BigInteger constructors taking a byte[] argument by improving guarantees of internal invariants.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8319174: Enhance robustness of some j.m.BigInteger constructors (Enhancement - P4)
• JDK-8319327: Enhance robustness of some j.m.BigInteger constructors (CSR) (Withdrawn)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16449/head:pull/16449
$ git checkout pull/16449

Update a local copy of the PR:
$ git checkout pull/16449
$ git pull https://git.openjdk.org/jdk.git pull/16449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16449

View PR using the GUI difftool:
$ git pr show -t 16449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16449.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (57043db1)
• 03: Full - Incremental (eafa99c1)
• 02: Full - Incremental (33a6ed36)
• 01: Full - Incremental (af2e4158)
• 00: Full (4fcd905d)

[rgiulietti]

/csr unneeded

[openjdk]

@rgiulietti determined that a CSR request is not needed for this pull request.

[RogerRiggs]

Looks good

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319174: Enhance robustness of some j.m.BigInteger constructors

Reviewed-by: rriggs, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• a95062b: 8319670: Improve comments describing system properties for TLS server and client for max chain length
• 38745ec: 8319649: inline_boxing_calls unused gvn variable
• 636a351: 8319429: Resetting MXCSR flags degrades ecore
• d7b0ba9: 8319554: Select LogOutput* directly for stdout and stderr
• 68110b7: 8319574: Exec/process tests should be marked as flagless
• 7b971c1: 8319705: RISC-V: signumF/D intrinsics fails compiler/intrinsics/math/TestSignumIntrinsic.java
• f939542: 8319324: FFM: Reformat javadocs
• a3f1b33: 8319664: IGV always output on PhaseRemoveUseless
• f57b78c: 8319726: Parallel GC: Re-use object in object-iterator
• 4451a92: 8319748: [JVMCI] TestUseCompressedOopsFlagsWithUlimit.java crashes on libgraal
• ... and 121 more: https://git.openjdk.org/jdk/compare/e05cafda78a37dbeb2df2edd791be19d22edaece...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

Looks fine.

May want to add some assert to verify the stated pre-conditions hold.

[rgiulietti]

/integrate

[openjdk]

Going to push as commit a64fc48.
Since your change was applied there have been 132 commits pushed to the master branch:

• 9cce9fe: 8319256: Print more diagnostic information when an unexpected user is found in a Phi
• a95062b: 8319670: Improve comments describing system properties for TLS server and client for max chain length
• 38745ec: 8319649: inline_boxing_calls unused gvn variable
• 636a351: 8319429: Resetting MXCSR flags degrades ecore
• d7b0ba9: 8319554: Select LogOutput* directly for stdout and stderr
• 68110b7: 8319574: Exec/process tests should be marked as flagless
• 7b971c1: 8319705: RISC-V: signumF/D intrinsics fails compiler/intrinsics/math/TestSignumIntrinsic.java
• f939542: 8319324: FFM: Reformat javadocs
• a3f1b33: 8319664: IGV always output on PhaseRemoveUseless
• f57b78c: 8319726: Parallel GC: Re-use object in object-iterator
• ... and 122 more: https://git.openjdk.org/jdk/compare/e05cafda78a37dbeb2df2edd791be19d22edaece...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit a64fc48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.