8187591: -Werror turns incubator module warning to an error

[asotona]

-Werror turns incubator module warning to an error
This patch adds "incubating" lint on-by-default category and triggers incubating module warning accordingly.
It also adds a test and updates javac man pages and jdk.compiler module-info javadoc.

Please review.

Thanks,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8319230 to be approved

Issues

• JDK-8187591: -Werror turns incubator module warning to an error (Bug - P3)
• JDK-8319230: -Werror turns incubator module warning to an error (CSR)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16454/head:pull/16454
$ git checkout pull/16454

Update a local copy of the PR:
$ git checkout pull/16454
$ git pull https://git.openjdk.org/jdk.git pull/16454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16454

View PR using the GUI difftool:
$ git pr show -t 16454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16454.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0aee6895)
• 00: Full (65378f60)

[lahodaj]

Looks OK to me.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8187591: -Werror turns incubator module warning to an error

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 252 new commits pushed to the master branch:

• 570dffb: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 21a59b9: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows
• 9232070: 8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength
• e055fae: 8264425: Update building.md on non-English locales on Windows
• c4aee66: 8320222: Wrong bytecode accepted, and StackMap table generated
• 604d29a: 8304446: javap --system flag doesn't override system APIs
• 839dd65: 8319244: implement JVMTI handshakes support for virtual threads
• 46e4028: 8316592: RISC-V: implement poly1305 intrinsic
• 3544d2d: 8319784: VM crash during heap dump after JDK-8287061
• 303757b: 8319879: Stress mode to randomize incremental inlining decision
• ... and 242 more: https://git.openjdk.org/jdk/compare/0064cf90ff7d575f3500a05e234dd795b15240b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[asotona]

/integrate

[openjdk]

Going to push as commit 53eb6f1.
Since your change was applied there have been 252 commits pushed to the master branch:

• 570dffb: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 21a59b9: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows
• 9232070: 8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength
• e055fae: 8264425: Update building.md on non-English locales on Windows
• c4aee66: 8320222: Wrong bytecode accepted, and StackMap table generated
• 604d29a: 8304446: javap --system flag doesn't override system APIs
• 839dd65: 8319244: implement JVMTI handshakes support for virtual threads
• 46e4028: 8316592: RISC-V: implement poly1305 intrinsic
• 3544d2d: 8319784: VM crash during heap dump after JDK-8287061
• 303757b: 8319879: Stress mode to randomize incremental inlining decision
• ... and 242 more: https://git.openjdk.org/jdk/compare/0064cf90ff7d575f3500a05e234dd795b15240b2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 53eb6f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.