8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false"

[mlchung]

TestLoadLibraryDeadlock.java test runs LoadLibraryDeadlock and wait for 5 seconds and then grab the output. Then run jcmd to dump the thread stacks in case there is a deadlock. The test ignores and swallows any exception which makes it hard to diagnose test issues.

This PR simplifies the test to use jdk.test.lib.process.ProcessTools to launch LoadLibraryDeadlock test so that the output and error will be captured in the same way as other tools are run by this test. Also update the test to propagate exceptions where appropriate. This hopes to collect more information to diagnose the issue if this test fails next time.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" (Bug - P4)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16459/head:pull/16459
$ git checkout pull/16459

Update a local copy of the PR:
$ git checkout pull/16459
$ git pull https://git.openjdk.org/jdk.git pull/16459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16459

View PR using the GUI difftool:
$ git pr show -t 16459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16459.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (962690fa)
• 00: Full (a4c8ebae)

[RogerRiggs]

The prose description talks about using ProcessTools, but the runCommand code doesn't use ProcessTools.createTestJavaProcessBuilder. It could save a few steps.

[mlchung]

runCommand sets the working directory whereas ProcessTools.createTestJavaProcessBuilder does not. Either way is okay with me if we want to use createTestJavaProcessBuilder (which will set the VM options).

+        ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("-cp",
+                                                                      "a.jar" + classPathSeparator +
+                                                                      "b.jar" + classPathSeparator +
+                                                                      "c.jar",
+                                                                      "-Djava.library.path=" + testLibraryPath,
+                                                                      "LoadLibraryDeadlock")
+                                        .directory(new File(testClassPath));
+        OutputAnalyzer outputAnalyzer = ProcessTools.executeCommand(pb)
+                .shouldHaveExitValue(0);

or set the class path to the explicit path of the JAR files.

[mlchung]

Updated to use createTestJavaProcessBuilder and more clean up.

[RogerRiggs]

Looks good.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false"

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f262f06: 8319211: Regression in LoopOverNonConstantFP

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

/integrate

[openjdk]

Going to push as commit 5207443.
Since your change was applied there have been 2 commits pushed to the master branch:

• ee57e73: 8317612: ChoiceFormat and MessageFormat constructors call non-final public method
• f262f06: 8319211: Regression in LoopOverNonConstantFP

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit 5207443.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.