Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246585: ForkJoin updates #1646

Closed
wants to merge 1 commit into from

Conversation

@Martin-Buchholz
Copy link
Member

@Martin-Buchholz Martin-Buchholz commented Dec 6, 2020

/cc core-libs


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8246585: ForkJoin updates
  • JDK-8229253: forkjoin/FJExceptionTableLeak.java fails "AssertionError: failed to satisfy condition"

Reviewers

  • Doug Lea (@DougLea - Reviewer) ⚠️ Review applies to c4d417b2d93fdaa76f152f02bfb71b6a9b5f2296

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1646/head:pull/1646
$ git checkout pull/1646

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 6, 2020

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the core-libs label Dec 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2020

@Martin-Buchholz
The core-libs label was successfully added.

Loading

@Martin-Buchholz Martin-Buchholz force-pushed the JDK-8246585 branch 2 times, most recently from 60dd456 to 8d5a803 Dec 6, 2020
@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Dec 6, 2020

/issue add JDK-8246585

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2020

@Martin-Buchholz This issue is referenced in the PR title - it will now be updated.

Loading

@Martin-Buchholz Martin-Buchholz force-pushed the JDK-8246585 branch 13 times, most recently from 5be6d6e to 0ae4684 Dec 8, 2020
@Martin-Buchholz Martin-Buchholz marked this pull request as ready for review Dec 8, 2020
@openjdk openjdk bot added the rfr label Dec 8, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2020

Webrevs

  • 04: Full - Incremental (cbd8188)
  • 03: Full (b10694b540d178ebb3b2a03e95761d3ad92ad3d1)
  • 02: Full (c4d417b2d93fdaa76f152f02bfb71b6a9b5f2296)
  • 01: Full - Incremental (d025f68b53a136862b6981b15201a851f0ef03c8)
  • 00: Full (0ae46847695a59853823392be9b6811d7f9a1715)

Loading

@shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 8, 2020

It would be nice to get it tested with GH Actions. "Checks" tabs should have those testing results automatically on push, but it is empty. Probably because your fork is not configured for it. Please go to https://github.com/Martin-Buchholz/jdk/actions -- and see if it says anything suspicious? Triggering the (only) workflow manually against your branch would help too.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2020

Mailing list message from Martin Buchholz on core-libs-dev:

On Tue, Dec 8, 2020 at 12:05 AM Aleksey Shipilev <shade at openjdk.java.net>
wrote:

On Sun, 6 Dec 2020 02:56:34 GMT, Martin Buchholz <martin at openjdk.org>
wrote:

8246585: ForkJoin updates

It would be nice to get it tested with GH Actions. "Checks" tabs should
have those testing results automatically on push, but it is empty. Probably
because your fork is not configured for it. Please go to
https://github.com/Martin-Buchholz/jdk/actions -- and see if it says
anything suspicious? Triggering the (only) workflow manually against your
branch would help too.

Thanks for the handholding. I visited
https://github.com/Martin-Buchholz/jdk/actions and it said

Workflows aren't being run on this forked repository

Because this repository contained workflow files when it was
forked, we have disabled them from running on this fork. Make sure
you understand the configured workflows and their expected usage
before enabling Actions on this repository.

They're now enabled. Do the skara docs need to clarify this?

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2020

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8246585: ForkJoin updates
8229253: forkjoin/FJExceptionTableLeak.java fails "AssertionError: failed to satisfy condition"

Reviewed-by: dl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6472104: 6278172: TextComponent.getSelectedText() throws StringIndexOutOfBoundsException
  • a653928: 8259512: Update --release 16 symbol information for JDK 16 build 31

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Jan 8, 2021

/solves JDK-8229253

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@Martin-Buchholz
Adding additional issue to solves list: 8229253: forkjoin/FJExceptionTableLeak.java fails "AssertionError: failed to satisfy condition".

Loading

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Jan 9, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 9, 2021

@Martin-Buchholz Since your change was applied there have been 2 commits pushed to the master branch:

  • 6472104: 6278172: TextComponent.getSelectedText() throws StringIndexOutOfBoundsException
  • a653928: 8259512: Update --release 16 symbol information for JDK 16 build 31

Your commit was automatically rebased without conflicts.

Pushed as commit 5cfa8c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants