Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) #16461

Closed
wants to merge 49 commits into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Nov 1, 2023

Address changes from JEP 445 to JEP 463.

  • Move from a SYNTHETIC unnamed class to a MANDATED implicit class.

  • Don't mark class on read.

  • Remove reflection and annotation processing related to unnamed classes.

  • Simplify main method search.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8319044 to be approved

Issues

  • JDK-8315458: Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) (Sub-task - P3)
  • JDK-8319044: CSR JEP 463: Core Reflection API changes for Implicitly Declared Classes (Second Preview) (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16461/head:pull/16461
$ git checkout pull/16461

Update a local copy of the PR:
$ git checkout pull/16461
$ git pull https://git.openjdk.org/jdk.git pull/16461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16461

View PR using the GUI difftool:
$ git pr show -t 16461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16461.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@JimLaskey The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 1, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

@AlanBateman
Copy link
Contributor

There's a number of .orig files that seem to have been checked in by mistake.

@JimLaskey
Copy link
Member Author

Re .orig. Thank you Alan.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor comments inline.

@pavelrappo
Copy link
Member

Jim, consider merging this PR with master to catch up. This PR is almost 250 commits behind master. That is a month of work. Also, if you merge, we could use this PR as a dependency for other PRs.

@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 28, 2023
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 29, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javac changes seem reasonably to me. Adding two nits to InstanceMainTest.java.

test/jdk/tools/launcher/InstanceMainTest.java Outdated Show resolved Hide resolved
test/jdk/tools/launcher/InstanceMainTest.java Outdated Show resolved Hide resolved
JimLaskey and others added 2 commits November 29, 2023 11:21
Co-authored-by: Jan Lahoda <51319204+lahodaj@users.noreply.github.com>
Co-authored-by: Jan Lahoda <51319204+lahodaj@users.noreply.github.com>
@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

Going to push as commit 04ad98e.
Since your change was applied there have been 43 commits pushed to the master branch:

  • 03759e8: 8320304: Refactor and simplify monitor deflation functions
  • da7cf25: 8320665: update jdk_core at open/test/jdk/TEST.groups
  • c9d15f7: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
  • 61653a1: 8320830: [AIX] Dont mix os::dll_load() with direct dlclose() calls
  • 8b102ed: 8321063: AArch64: Zero build fails after JDK-8320368
  • 6941369: 8320921: GHA: Parallelize hotspot_compiler test jobs
  • 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object
  • d6b4aa0: 8318157: RISC-V: implement ensureMaterializedForStackWalk intrinsic
  • 7766785: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 940f67c: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • ... and 33 more: https://git.openjdk.org/jdk/compare/dc256fbc6490f8163adb286dbb7380c10e5e1e06...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2023
@openjdk openjdk bot closed this Nov 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@JimLaskey Pushed as commit 04ad98e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org